Bug 239609 - [GBM] Debug build broken
Summary: [GBM] Debug build broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-21 09:31 PDT by Philippe Normand
Modified: 2022-04-21 10:44 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2022-04-21 09:31:17 PDT
Missing Logging.h include:

/app/webkit/Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp:226:18: error: use of undeclared identifier 'LOG_CHANNEL_PREFIXWebGL'
        do { if (LOG_CHANNEL_PREFIXWebGL.state != logChannelStateOff) WTFLog(&LOG_CHANNEL_PREFIXWebGL, "EGLDisplay Initialization failed."); } while (0);
                 ^
/app/webkit/Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp:226:79: error: use of undeclared identifier 'LOG_CHANNEL_PREFIXWebGL'
        do { if (LOG_CHANNEL_PREFIXWebGL.state != logChannelStateOff) WTFLog(&LOG_CHANNEL_PREFIXWebGL, "EGLDisplay Initialization failed."); } while (0);
                                                                              ^
/app/webkit/Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp:229:14: error: use of undeclared identifier 'LOG_CHANNEL_PREFIXWebGL'
    do { if (LOG_CHANNEL_PREFIXWebGL.state != logChannelStateOff) WTFLog(&LOG_CHANNEL_PREFIXWebGL, "ANGLE initialised Major: %d Minor: %d", majorVersion, minorVersion); } while (0);
             ^
Comment 1 Philippe Normand 2022-04-21 09:36:10 PDT
https://github.com/WebKit/WebKit/pull/346
Comment 2 EWS 2022-04-21 10:44:22 PDT
Committed r293177 (249859@main): <https://commits.webkit.org/249859@main>

Reviewed commits have been landed. Closing PR #346 and removing active labels.