Bug 23959 - LayoutTests/fast/dom/navigator-detached-no-crash.html fails with other JS engines
Summary: LayoutTests/fast/dom/navigator-detached-no-crash.html fails with other JS eng...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-13 17:29 PST by Jay Campan
Modified: 2009-02-19 14:20 PST (History)
1 user (show)

See Also:


Attachments
Changes the test so it sorts the properties and functions before logging them (3.85 KB, patch)
2009-02-13 17:30 PST, Jay Campan
ap: review+
Details | Formatted Diff | Diff
New patch with ChangeLog fixed. (3.38 KB, patch)
2009-02-17 15:01 PST, Jay Campan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Campan 2009-02-13 17:29:04 PST
The layout test fast/dom/navigator-detached-no-crash.html fails with V8 as it iterates the properties and methods of the navigator object and log them as they are reported.
JSC and V8 report these properties in different order (which is OK by JS specs I believe) causing the test to fail with Chromium.

The test should probably sort these props before logging them so the order would always be the same.
Comment 1 Jay Campan 2009-02-13 17:30:49 PST
Created attachment 27677 [details]
Changes the test  so it sorts the properties and functions before logging them
Comment 2 Alexey Proskuryakov 2009-02-14 02:40:46 PST
Do IE and Firefox sort these properties in the same order as WebKit?
Comment 3 Alexey Proskuryakov 2009-02-17 02:17:24 PST
Comment on attachment 27677 [details]
Changes the test  so it sorts the properties and functions before logging them

Ok, Firefox sorts differently, so r=me. But this patch includes a wrong ChangeLog, which must be fixed.
Comment 4 Jay Campan 2009-02-17 15:01:40 PST
Created attachment 27739 [details]
New patch with ChangeLog fixed.

ChangeLog fixed in new attachment (sorry, forgot to run prepare-changelog previously)
Comment 5 Dmitry Titov 2009-02-19 14:20:44 PST
Landed in http://trac.webkit.org/changeset/41087

The ChangeLog usually includes a link to the bug in Bugzilla and a short description of changes.
I've fixed it up and landed.