Bug 239589 - Web Inspector: [WebGL] Display bitfields as combination of named constants
Summary: Web Inspector: [WebGL] Display bitfields as combination of named constants
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Dan Glastonbury
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-20 22:03 PDT by Dan Glastonbury
Modified: 2022-05-02 18:00 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Glastonbury 2022-04-20 22:03:19 PDT
Currently there are a few places in WebGL that take a GLbitfield of "or"ed flags. Instead of rendering the numeric value of the flags, it would be better to display the descriptive names of the flags. Eg:

`clear(context.COLOR_BUFFER_BIT|context.DEPTH_BUFFER_BIT|context.STENCIL_BUFFER_BIT)`

instead of:

`clear(17664)`
Comment 1 Dan Glastonbury 2022-04-21 02:50:33 PDT
Pull request: https://github.com/WebKit/WebKit/pull/341
Comment 2 Radar WebKit Bug Importer 2022-04-27 22:04:12 PDT
<rdar://problem/92439695>
Comment 3 EWS 2022-05-02 18:00:11 PDT
Committed r293706 (250195@main): <https://commits.webkit.org/250195@main>

Reviewed commits have been landed. Closing PR #341 and removing active labels.