Bug 23958 - Access-Control-Origin header is now called Access-Control-Allow-Origin
Summary: Access-Control-Origin header is now called Access-Control-Allow-Origin
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Nobody
URL: http://www.w3.org/TR/access-control/
Keywords: InRadar
Depends on:
Reported: 2009-02-13 16:00 PST by Peter Abrahamsen
Modified: 2009-02-17 16:23 PST (History)
2 users (show)

See Also:

Patch to rename header across code base (16.38 KB, patch)
2009-02-13 16:02 PST, Peter Abrahamsen
no flags Details | Formatted Diff | Diff
Updated patch (18.91 KB, patch)
2009-02-16 14:06 PST, Peter Abrahamsen
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Abrahamsen 2009-02-13 16:00:56 PST
Investigating why my application worked in FF3.1 betas and not webkit, I found that webkit was following an earlier draft of the access-control spec. The current working draft, at the URL above, makes no mention of an Access-Control-Origin header.

The patch I will attach shortly is pretty much a sed -i of a bunch of files in the repo. I was able to confirm that the change fixed my application, but I couldn't figure out how to get the regression tests to run. The change is simple enough that I don't think this patch will break them (fingers crossed).
Comment 1 Peter Abrahamsen 2009-02-13 16:02:18 PST
Created attachment 27673 [details]
Patch to rename header across code base
Comment 2 Alexey Proskuryakov 2009-02-14 00:58:18 PST
Comment on attachment 27673 [details]
Patch to rename header across code base

There are tabs in ChangeLog, which will need to be converted to spaces. And, LayoutTests ChangeLog doesn't have an e-mail address. Both are trivial issues that could be fixed by the person landing this patch.

We also need to rename Access-Control-Credentials to Access-Control-Allow-Credentials. Would you be willing to make a patch that fixes both headers? Please mark it for review when/if you do, so that it doesn't get lost.
Comment 3 Alexey Proskuryakov 2009-02-14 00:59:24 PST
Comment 4 Alexey Proskuryakov 2009-02-14 01:07:29 PST
To run layout tests, you can enter the following command in Terminal (with the current directory being WebKit root):


To only run tests from http subdirectory, use

WebKitTools/Scripts/run-webkit-tests http
Comment 5 Peter Abrahamsen 2009-02-16 14:06:03 PST
Created attachment 27708 [details]
Updated patch

Updated patch with entries in both ChangeLogs (sans tabs) and with the renamed Access-Control-Allow-Credentials header. All tests pass.
Comment 6 Peter Abrahamsen 2009-02-16 14:08:56 PST
Hi, sorry, I don't know where to mark the patch for review, but it's ready.
Comment 7 Alexey Proskuryakov 2009-02-16 14:26:08 PST
Comment on attachment 27708 [details]
Updated patch

Thanks! This looks good to me - but I think that Sam should ideally take a look.
Comment 8 Sam Weinig 2009-02-16 15:01:10 PST
Comment on attachment 27708 [details]
Updated patch

Comment 9 Dmitry Titov 2009-02-17 16:23:13 PST
Landed: http://trac.webkit.org/changeset/41046