Bug 239570 - [ iOS ] platform/ios/ios/fast/text/opticalFont.html is a constant failure
Summary: [ iOS ] platform/ios/ios/fast/text/opticalFont.html is a constant failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-20 15:39 PDT by Truitt Savell
Modified: 2022-04-20 19:49 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.30 KB, patch)
2022-04-20 17:57 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2022-04-20 17:58 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2022-04-20 15:39:32 PDT
platform/ios/ios/fast/text/opticalFont.html 

This test is a constant failure on iOS, I think it just needs a rebase as the pixels are off by one. 

History:
https://results.webkit.org/?suite=layout-tests&test=platform%2Fios%2Fios%2Ffast%2Ftext%2FopticalFont.html

Diff:
--- /Volumes/Data/worker/ios-simulator-15-release-tests-wk2/build/layout-test-results/platform/ios/ios/fast/text/opticalFont-expected.txt
+++ /Volumes/Data/worker/ios-simulator-15-release-tests-wk2/build/layout-test-results/platform/ios/ios/fast/text/opticalFont-actual.txt
@@ -12,13 +12,13 @@
       RenderBlock {DIV} at (0,58) size 784x74
         RenderText {#text} at (0,0) size 679x74
           text run at (0,0) width 679: "This is a test for -webkit-system-font, using the 'font'"
-          text run at (0,37) width 109: "property"
+          text run at (0,37) width 110: "property"
       RenderBlock {DIV} at (0,132) size 784x37
-        RenderText {#text} at (0,0) size 717x37
-          text run at (0,0) width 717: "This is a test for -apple-system, using the 'font' property"
+        RenderText {#text} at (0,0) size 718x37
+          text run at (0,0) width 718: "This is a test for -apple-system, using the 'font' property"
       RenderBlock {DIV} at (0,169) size 784x37
-        RenderText {#text} at (0,0) size 655x37
-          text run at (0,0) width 655: "This is a test for system-ui, using the 'font' property"
+        RenderText {#text} at (0,0) size 656x37
+          text run at (0,0) width 656: "This is a test for system-ui, using the 'font' property"
       RenderBlock {DIV} at (0,206) size 784x29
         RenderInline {B} at (0,0) size 552x29
           RenderText {#text} at (0,0) size 552x29
Comment 1 Radar WebKit Bug Importer 2022-04-20 15:40:13 PDT
<rdar://problem/92056238>
Comment 2 Myles C. Maxfield 2022-04-20 15:42:29 PDT
Yes, I agree that this should just be rebased.
Comment 3 Myles C. Maxfield 2022-04-20 17:57:09 PDT
Created attachment 458024 [details]
Patch
Comment 4 Myles C. Maxfield 2022-04-20 17:58:54 PDT
Created attachment 458025 [details]
Patch
Comment 5 Myles C. Maxfield 2022-04-20 18:06:36 PDT
Comment on attachment 458025 [details]
Patch

Truitt says this is the right direction.
Comment 6 EWS 2022-04-20 19:49:33 PDT
Committed r293140 (249838@main): <https://commits.webkit.org/249838@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458025 [details].