Bug 239560 - Address recent deprecation warnings on iOS
Summary: Address recent deprecation warnings on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-20 12:54 PDT by Megan Gardner
Modified: 2022-04-20 20:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (19.80 KB, patch)
2022-04-20 12:55 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (19.59 KB, patch)
2022-04-20 14:03 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (19.58 KB, patch)
2022-04-20 14:08 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2022-04-20 12:54:33 PDT 
Move off of depricated methods and add allow deprication for harder to refector code.
Comment 1 Megan Gardner 2022-04-20 12:55:50 PDT 
Created attachment 458005 [details]
Patch
Comment 2 Wenson Hsieh 2022-04-20 13:07:58 PDT 
Comment on attachment 458005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458005&action=review

> Source/WebKit/ChangeLog:3
> +        Move off of depricated methods and add allow deprication for harder to refector code.

Nit - Spelling errors, but I would also just change this to something like:

"Address recent deprecation warnings on iOS"

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:288
> +    //[item setDontDismiss:!_customMenuActionInfo->dismissesAutomatically];

It's not clear to me why this is going away. IIRC, the layout test that uses this bit checks that the WebKit client can install a custom action in the callout bar that is configured to not dismiss the callout bar when activated (this simulates what Mail on iOS does in compose).
Comment 3 Megan Gardner 2022-04-20 14:03:18 PDT 
Created attachment 458012 [details]
Patch
Comment 4 Megan Gardner 2022-04-20 14:08:27 PDT 
Created attachment 458013 [details]
Patch for landing
Comment 5 EWS 2022-04-20 14:44:10 PDT 
Committed r293117 (249823@main): <https://commits.webkit.org/249823@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458013 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-20 14:45:14 PDT 
<rdar://problem/92052936>
Comment 7 Simon Fraser (smfr) 2022-04-20 20:34:26 PDT 
This broke internal iOS builds against 15.4 SDKs
Comment 8 Wenson Hsieh 2022-04-20 20:58:13 PDT 
(In reply to Simon Fraser (smfr) from comment #7)
> This broke internal iOS builds against 15.4 SDKs

Landed https://trac.webkit.org/r293142