Bug 239560 – Address recent deprecation warnings on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Move off of depricated methods and add allow deprication for harder to refector code.

[Megan Gardner]

Created attachment 458005 [details]
Patch

[Wenson Hsieh]

Comment on attachment 458005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458005&action=review

> Source/WebKit/ChangeLog:3
> +        Move off of depricated methods and add allow deprication for harder to refector code.

Nit - Spelling errors, but I would also just change this to something like:

"Address recent deprecation warnings on iOS"

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:288
> +    //[item setDontDismiss:!_customMenuActionInfo->dismissesAutomatically];

It's not clear to me why this is going away. IIRC, the layout test that uses this bit checks that the WebKit client can install a custom action in the callout bar that is configured to not dismiss the callout bar when activated (this simulates what Mail on iOS does in compose).

[Megan Gardner]

Created attachment 458012 [details]
Patch

[Megan Gardner]

Created attachment 458013 [details]
Patch for landing

[EWS]

Committed r293117 (249823@main): <https://commits.webkit.org/249823@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458013 [details].

[Radar WebKit Bug Importer]

<rdar://problem/92052936>

[Simon Fraser (smfr)]

This broke internal iOS builds against 15.4 SDKs

[Wenson Hsieh]

(In reply to Simon Fraser (smfr) from comment #7)
> This broke internal iOS builds against 15.4 SDKs

Landed https://trac.webkit.org/r293142