Bug 23955 - V8HTMLPlugInCustom returns undefined, which fools interceptors.
Summary: V8HTMLPlugInCustom returns undefined, which fools interceptors.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-13 13:47 PST by Dimitri Glazkov (Google)
Modified: 2009-02-18 10:47 PST (History)
0 users

See Also:


Attachments
V8HTMLPlugInCustom returns undefined, which fools interceptors, v1 (3.24 KB, patch)
2009-02-13 13:50 PST, Dimitri Glazkov (Google)
eric: review-
Details | Formatted Diff | Diff
V8HTMLPlugInCustom returns undefined, which fools interceptors, v2 (3.22 KB, patch)
2009-02-13 16:04 PST, Dimitri Glazkov (Google)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-02-13 13:47:38 PST
V8 interceptors need a truly empty value, rather than undefined. Sad.
Comment 1 Dimitri Glazkov (Google) 2009-02-13 13:50:27 PST
Created attachment 27668 [details]
V8HTMLPlugInCustom returns undefined, which fools interceptors, v1

 WebCore/ChangeLog                                  |   13 +++++++++++++
 .../v8/custom/V8HTMLPlugInElementCustom.cpp        |   16 ++++++++--------
 2 files changed, 21 insertions(+), 8 deletions(-)
Comment 2 Eric Seidel (no email) 2009-02-13 14:01:28 PST
Comment on attachment 27668 [details]
V8HTMLPlugInCustom returns undefined, which fools interceptors, v1

We're talking about something prettier, and involving more pink ponies and less scary undocumented subtitles in #webkit.  No biscuit for this patch!
Comment 3 Dimitri Glazkov (Google) 2009-02-13 16:04:19 PST
Created attachment 27674 [details]
V8HTMLPlugInCustom returns undefined, which fools interceptors, v2

 WebCore/ChangeLog                                  |   13 +++++++++++++
 .../v8/custom/V8HTMLPlugInElementCustom.cpp        |   16 ++++++++--------
 2 files changed, 21 insertions(+), 8 deletions(-)
Comment 4 Eric Seidel (no email) 2009-02-13 21:05:50 PST
Comment on attachment 27674 [details]
V8HTMLPlugInCustom returns undefined, which fools interceptors, v2

LGTM.
Comment 5 Dimitri Glazkov (Google) 2009-02-18 10:47:47 PST
Landed as http://trac.webkit.org/changeset/41017.