AX: The isolated tree is not updated after role changes in AccessibilityRenderObject::updateRoleAfterChildrenCreation()

[Tyler Wilcock]

The isolated tree is not updated after role changes in AccessibilityRenderObject::updateRoleAfterChildrenCreation()

[Radar WebKit Bug Importer]

<rdar://problem/92036686>

[Tyler Wilcock]

Created attachment 457995 [details]
Patch

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #2)
> Created attachment 457995 [details]
> Patch

--- a/LayoutTests/accessibility/mac/invalid-menu-role-does-not-send-notification.html
+++ a/LayoutTests/accessibility/mac/invalid-menu-role-does-not-send-notification.html

+        accessibilityController.addNotificationListener(() => {

Shouldn't the => function take a parameter notification? JS is probably this tolerant, but not sure.

[Tyler Wilcock]

Created attachment 458079 [details]
Patch

[Tyler Wilcock]

> +        accessibilityController.addNotificationListener(() => {
> 
> Shouldn't the => function take a parameter notification? JS is probably this
> tolerant, but not sure.
Fixed.

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #5)
> > +        accessibilityController.addNotificationListener(() => {
> > 
> > Shouldn't the => function take a parameter notification? JS is probably this
> > tolerant, but not sure.
> Fixed.

Actually looking at the other instances of accessibilityController.addNotificationListener((element, notification) => {, they always have two parameters, the accessible element and the notification name. this is unlike the DoM notification which is an object that encapsulates the target and the type of the notification.

[Tyler Wilcock]

Created attachment 458083 [details]
Patch

[EWS]

Committed r293212 (249883@main): <https://commits.webkit.org/249883@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458083 [details].