RESOLVED FIXED 239542
generate-automation-atom.py breaks under older python with non-ascii inputs 
https://bugs.webkit.org/show_bug.cgi?id=239542
Summary generate-automation-atom.py breaks under older python with non-ascii inputs
Daniel Kolesa
Reported 2022-04-20 07:36:27 PDT
File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode return codecs.ascii_decode(input, self.errors)[0] UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 1983: ordinal not in range(128) for Source/WebKit/UIProcess/Automation/atoms/FindNodes.js This is because of https://github.com/q66/WebKit/blob/main/Source/WebKit/UIProcess/Automation/atoms/FindNodes.js#L123 (the § character)
Attachments
patch (2.31 KB, patch)
2022-04-20 07:38 PDT, Daniel Kolesa 		no flags
DetailsFormatted DiffDiff
fix style (1.59 KB, patch)
2022-04-20 07:43 PDT, Daniel Kolesa 		no flags
DetailsFormatted DiffDiff
fixed patch (2.30 KB, patch)
2022-04-20 07:47 PDT, Daniel Kolesa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Kolesa
Comment 1 2022-04-20 07:38:34 PDT
Created attachment 457987 [details] patch
Daniel Kolesa
Comment 2 2022-04-20 07:43:45 PDT
Created attachment 457989 [details] fix style
Daniel Kolesa
Comment 3 2022-04-20 07:47:00 PDT
Created attachment 457990 [details] fixed patch
Adrian Perez
Comment 4 2022-04-24 14:12:54 PDT
Comment on attachment 457990 [details] fixed patch The failure from the ios-wk2 builder is unrelated, let's land this.
EWS
Comment 5 2022-04-24 14:17:55 PDT
Committed r293307 (249930@main): <https://commits.webkit.org/249930@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457990 [details].
Radar WebKit Bug Importer
Comment 6 2022-04-24 14:18:14 PDT
<rdar://problem/92238946>
Note You need to log in before you can comment on or make changes to this bug.