Bug 239538 – [GTK] Deprecate WebKitSettings:enable-java

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Somehow we forgot to deprecate enable-java. It should be removed from GTK 4 API, and deprecated with GTK 3.

[Michael Catanzaro]

Also: enable-xss-auditor

[Lauro Moura]

Pull request: https://github.com/WebKit/WebKit/pull/1004

[Lauro Moura]

Updating summary after 250038@main handled enable-xss-auditor.

[Michael Catanzaro]

(In reply to Lauro Moura from comment #3)
> Updating summary after 250038@main handled enable-xss-auditor.

I'm going to un-update the summary since enable-xss-auditor is deprecated, but has not been removed yet. It shouldn't exist at all in the GTK 4 API version.

[Michael Catanzaro]

Well, actually, never mind. We don't actually need separate bugs to track removal of deprecated stuff. We have https://bugs.webkit.org/show_bug.cgi?id=235151 for that.

[EWS]

Committed r294920 (251036@main): <https://commits.webkit.org/251036@main>

Reviewed commits have been landed. Closing PR #1004 and removing active labels.

[Philippe Normand]

Introduced warnings:

                                                                     ^
/app/webkit/WebKitBuild/Release/WebKit2Gtk/Headers/webkit2/WebKitSettings.h:159:55: note: 'webkit_settings_get_enable_java' has been explicitly marked deprecated here
__attribute__((visibility("default"))) __attribute__((__deprecated__)) gboolean
                                                      ^
/app/webkit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:84:5: warning: 'webkit_settings_set_enable_java' is deprecated [-Wdeprecated-declarations]
    webkit_settings_set_enable_java(settings, (0));
    ^
/app/webkit/WebKitBuild/Release/WebKit2Gtk/Headers/webkit2/WebKitSettings.h:162:55: note: 'webkit_settings_set_enable_java' has been explicitly marked deprecated here
__attribute__((visibility("default"))) __attribute__((__deprecated__)) void
                                                      ^
/app/webkit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:85:76: warning: 'webkit_settings_get_enable_java' is deprecated [-Wdeprecated-declarations]
    do { if (__builtin_expect (__extension__ ({ int _g_boolean_var_; if (!(webkit_settings_get_enable_java(settings))) _g_boolean_var_ = 1; else _g_boolean_var_ = 0; _g_boolean_var_; }), 1)) ; else g_assertion_message (((gchar*) 0), "/app/webkit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp", 85, ((const char*) (__PRETTY_FUNCTION__)), "'" "webkit_settings_get_enable_java(settings)" "' should be FALSE"); } while (0);
                                                                           ^
/app/webkit/WebKitBuild/Release/WebKit2Gtk/Headers/webkit2/WebKitSettings.h:159:55: note: 'webkit_settings_get_enable_java' has been explicitly marked deprecated here
__attribute__((visibility("default"))) __attribute__((__deprecated__)) gboolean
                                                      ^
3 warnings generated.

[Michael Catanzaro]

Reopening to fix warnings.

[Lauro Moura]

Pull request: https://github.com/WebKit/WebKit/pull/1098

[EWS]

Committed r294942 (251052@main): <https://commits.webkit.org/251052@main>

Reviewed commits have been landed. Closing PR #1098 and removing active labels.