Bug 239516 - Various WebKit tools need to be told about the system content path
Summary: Various WebKit tools need to be told about the system content path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-19 13:10 PDT by Michael Saboff
Modified: 2022-04-19 16:23 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.13 KB, patch)
2022-04-19 13:22 PDT, Michael Saboff 		darin: review+
Details | Formatted Diff | Diff
Updated Patch (7.60 KB, patch)
2022-04-19 15:40 PDT, Michael Saboff 		ryanhaddad: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2022-04-19 13:10:45 PDT 
When we build JavaScriptCore tools with the system content path, they end up in the standard path.

We need to add the system content path to the install path.
Comment 1 Michael Saboff 2022-04-19 13:11:01 PDT 
<rdar://91910145>
Comment 2 Michael Saboff 2022-04-19 13:22:09 PDT 
Created attachment 457932 [details]
Patch
Comment 3 Darin Adler 2022-04-19 13:26:24 PDT 
Comment on attachment 457932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457932&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        This will and the system content path prefix when enabled.

"This will and the"?
Comment 4 Michael Saboff 2022-04-19 13:39:45 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 457932 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457932&action=review
> 
> > Source/JavaScriptCore/ChangeLog:9
> > +        This will and the system content path prefix when enabled.
> 
> "This will and the"?

Will fix.
Comment 5 Michael Saboff 2022-04-19 15:07:59 PDT 
Through some local testing, the WebKit testing tools like DumpRenderTree and WebKitTestRunner need to be educated about the system content path.  Patch forthcoming.
Comment 6 Michael Saboff 2022-04-19 15:40:23 PDT 
Created attachment 457939 [details]
Updated Patch

Added changes for WebKit testing tools.
Comment 7 Michael Saboff 2022-04-19 16:23:32 PDT 
Committed r293043 (249782@trunk): <https://commits.webkit.org/249782@trunk>