Bug 239508 - [iOS] Dictation text that contains emojis is inserted twice upon finalization
Summary: [iOS] Dictation text that contains emojis is inserted twice upon finalization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on: 239467
Blocks:
  Show dependency tree / graph
 
Reported: 2022-04-19 10:38 PDT by Wenson Hsieh
Modified: 2022-04-19 17:26 PDT (History)
8 users (show)

See Also:

Attachments
Patch (7.04 KB, patch)
2022-04-19 12:06 PDT, Wenson Hsieh 		akeerthi: review+
Details | Formatted Diff | Diff
Address comment (7.03 KB, patch)
2022-04-19 15:02 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2022-04-19 10:38:46 PDT 
rdar://91895524
Comment 1 Wenson Hsieh 2022-04-19 12:06:33 PDT 
Created attachment 457924 [details]
Patch
Comment 2 Chris Dumez 2022-04-19 14:28:32 PDT 
Comment on attachment 457924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457924&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2406
> +    for (size_t i = 0; i < numGraphemeClusters(oldText); ++i)

Shouldn't we cache numGraphemeClusters(oldText) before the loop? Or is oldText changing as we iterate?
Comment 3 Wenson Hsieh 2022-04-19 14:29:21 PDT 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 457924 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457924&action=review
> 
> > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2406
> > +    for (size_t i = 0; i < numGraphemeClusters(oldText); ++i)
> 
> Shouldn't we cache numGraphemeClusters(oldText) before the loop? Or is
> oldText changing as we iterate?

Good catch! `oldText` isn't changing, so we should pull this out into a local variable. I'll fix this before landing.
Comment 4 Wenson Hsieh 2022-04-19 15:02:30 PDT 
Created attachment 457938 [details]
Address comment
Comment 5 EWS 2022-04-19 17:26:26 PDT 
Committed r293051 (249786@main): <https://commits.webkit.org/249786@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457938 [details].