rdar://91895524
Created attachment 457924 [details] Patch
Comment on attachment 457924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457924&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2406 > + for (size_t i = 0; i < numGraphemeClusters(oldText); ++i) Shouldn't we cache numGraphemeClusters(oldText) before the loop? Or is oldText changing as we iterate?
(In reply to Chris Dumez from comment #2) > Comment on attachment 457924 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457924&action=review > > > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2406 > > + for (size_t i = 0; i < numGraphemeClusters(oldText); ++i) > > Shouldn't we cache numGraphemeClusters(oldText) before the loop? Or is > oldText changing as we iterate? Good catch! `oldText` isn't changing, so we should pull this out into a local variable. I'll fix this before landing.
Created attachment 457938 [details] Address comment
Committed r293051 (249786@main): <https://commits.webkit.org/249786@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457938 [details].