Bug 239499 – Only AXIsolatedTree::update{Children,Node} once when processing notifications in AXObjectCache::updateIsolatedTree

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

Currently, we do try to prevent performing duplicate updates, but we do so only if we have an exact match for a previous notification for any given object:

case AXTextChanged:
case AXValueChanged: {

    bool needsUpdate = appendIfNotContainsMatching(filteredNotifications, notification, [&notification] (const std::pair<RefPtr<AXCoreObject>, AXNotification>& note) {
       return note.second == notification.second && note.first.get() == notification.first.get();
    });

    if (needsUpdate)
        tree->updateNode(*notification.first);
   

However, multiple notifications trigger AXIsolatedTree::updateNode and children, so we'll still do wasted work in this case. For example, in the above snippet, we'd update the node twice if the same object got both an AXTextChanged and AXValueChanged notification in the same batch.

[Radar WebKit Bug Importer]

<rdar://problem/91961437>

[Tyler Wilcock]

Created attachment 457894 [details]
Patch

[Tyler Wilcock]

Created attachment 457903 [details]
Patch

[EWS]

Committed r293186 (249862@main): <https://commits.webkit.org/249862@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457903 [details].