Bug 239480 – [Cocoa] Add explanatory comments in fillVectorWithVerticalGlyphPositions() and simplify it somewhat

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[Cocoa] Add explanatory comments in fillVectorWithVerticalGlyphPositions() and simplify it somewhat

[Myles C. Maxfield]

Created attachment 457851 [details]
Patch

[Myles C. Maxfield]

Created attachment 457857 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 457857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457857&action=review

> Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:228
> +    // +------------A-------------+

I might want to add a point C ...

> Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:255
> +    // adjust the pen position to start there. WebKit's text routines start out using the alphabetic baseline so we adjust the start position

... and reference it it here.

[Myles C. Maxfield]

Comment on attachment 457857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457857&action=review

> Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:68
>      result.setB(-result.b());
>      result.setD(-result.d());

I probably should also add a comment here saying that this is a Y-flip

[Myles C. Maxfield]

Created attachment 457862 [details]
Patch

[Myles C. Maxfield]

Created attachment 457863 [details]
Patch

[zalan]

Comment on attachment 457863 [details]
Patch

great comment.

[EWS]

Committed r293032 (249771@main): <https://commits.webkit.org/249771@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457863 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91980794>