Bug 239480 - [Cocoa] Add explanatory comments in fillVectorWithVerticalGlyphPositions() and simplify it somewhat
Summary: [Cocoa] Add explanatory comments in fillVectorWithVerticalGlyphPositions() an...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 239484
  Show dependency tree / graph
 
Reported: 2022-04-18 20:22 PDT by Myles C. Maxfield
Modified: 2022-04-19 13:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (13.73 KB, patch)
2022-04-18 20:28 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (13.74 KB, patch)
2022-04-18 22:42 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (15.98 KB, patch)
2022-04-19 00:02 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (15.98 KB, patch)
2022-04-19 00:04 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-04-18 20:22:25 PDT 
[Cocoa] Add explanatory comments in fillVectorWithVerticalGlyphPositions() and simplify it somewhat
Comment 1 Myles C. Maxfield 2022-04-18 20:28:27 PDT 
Created attachment 457851 [details]
Patch
Comment 2 Myles C. Maxfield 2022-04-18 22:42:22 PDT 
Created attachment 457857 [details]
Patch
Comment 3 Myles C. Maxfield 2022-04-18 23:36:06 PDT 
Comment on attachment 457857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457857&action=review

> Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:228
> +    // +------------A-------------+

I might want to add a point C ...

> Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:255
> +    // adjust the pen position to start there. WebKit's text routines start out using the alphabetic baseline so we adjust the start position

... and reference it it here.
Comment 4 Myles C. Maxfield 2022-04-18 23:39:18 PDT 
Comment on attachment 457857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457857&action=review

> Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:68
>      result.setB(-result.b());
>      result.setD(-result.d());

I probably should also add a comment here saying that this is a Y-flip
Comment 5 Myles C. Maxfield 2022-04-19 00:02:03 PDT 
Created attachment 457862 [details]
Patch
Comment 6 Myles C. Maxfield 2022-04-19 00:04:27 PDT 
Created attachment 457863 [details]
Patch
Comment 7 zalan 2022-04-19 11:31:12 PDT 
Comment on attachment 457863 [details]
Patch

great comment.
Comment 8 EWS 2022-04-19 13:09:47 PDT 
Committed r293032 (249771@main): <https://commits.webkit.org/249771@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457863 [details].
Comment 9 Radar WebKit Bug Importer 2022-04-19 13:10:14 PDT 
<rdar://problem/91980794>