Bug 239462 – Implement CSSTransformValue.is2D

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Implement CSSTransformValue.is2D

[Alex Christensen]

Created attachment 457819 [details]
Patch

[Alex Christensen]

Created attachment 457831 [details]
Patch

[EWS]

Committed r293005 (249744@main): <https://commits.webkit.org/249744@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457831 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91934123>

[Darin Adler]

Comment on attachment 457831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457831&action=review

> Source/WebCore/css/typedom/numeric/CSSNumericType.h:80
> +    const std::optional<long>& valueForType(CSSNumericBaseType type) const

This seems like the wrong return type. Should just be std::optional<long>.

> Source/WebCore/css/typedom/transform/CSSPerspective.h:42
> +    static ExceptionOr<Ref<CSSPerspective>> create(CSSPerspectiveValue);

Why pass by value instead of by rvalue reference? I see this change throughout this patch and I don’t understand the rationale. For bindings, I guess both are the same, we will WTFMove from the local to the argument and then from the argument inside the function. But how did you decide this is the preferred style?

> Source/WebCore/css/typedom/transform/CSSTransformComponent.h:53
> +    CSSTransformComponent(Is2D is2D)

explicit

> Source/WebCore/css/typedom/transform/CSSTransformComponent.h:64
> -    bool m_is2D { false };
> +    Is2D m_is2D;

Why change the type of the data member?