Bug 239456 - Remove the deprecated CaptivePortal enablement key
Summary: Remove the deprecated CaptivePortal enablement key
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-18 11:16 PDT by Brent Fulgham
Modified: 2022-04-18 14:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.51 KB, patch)
2022-04-18 11:19 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2022-04-18 11:16:26 PDT 
Remove the temporary "WebKitCaptivePortalModeEnabled" preference as we now have a real preference to handle this use case.
Comment 1 Brent Fulgham 2022-04-18 11:19:02 PDT 
Created attachment 457812 [details]
Patch
Comment 2 Brent Fulgham 2022-04-18 11:21:58 PDT 
<rdar://88486480>
Comment 3 Wenson Hsieh 2022-04-18 11:57:27 PDT 
Comment on attachment 457812 [details]
Patch

rs=me
Comment 4 Brent Fulgham 2022-04-18 12:35:40 PDT 
It looks like the gtk-wk2 build failure is unrelated to this patch (some kind of out-of-space issue).
Comment 5 EWS 2022-04-18 14:38:46 PDT 
Committed r292972 (249735@main): <https://commits.webkit.org/249735@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457812 [details].