Use convertToASCIILowercase() less and more SortedArrayMap / SortedArraySet.
Created attachment 457807 [details] Patch
Created attachment 457809 [details] Patch
Comment on attachment 457809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457809&action=review > Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp:157 > + if (auto* displayValue = displayValues.tryGet(StringView(stringValue).stripWhiteSpace())) Not changing in this patch: Seems like this should be stripping leading and trailing *HTML* whitespace, probably a subtle and unimportant that it strips all *ASCII* whitespace, which includes one character that HTML does not. I also think itβs a little strange that the StringView function is named stripWhiteSpace, because we normally say ASCIISpace or HTMLSpace or HTTPSpace and just "space" typically means some kind of Unicode space. > Source/WebDriver/WebDriverService.cpp:232 > + if (auto* methodValue = httpMethods.tryGet(method)) > + return *methodValue; > return std::nullopt; Makes me wish we had a "convert pointer to optional" function you could have used here.
Committed r292976 (249739@main): <https://commits.webkit.org/249739@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457809 [details].
<rdar://problem/91921586>
Comment on attachment 457809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457809&action=review > Source/WebCore/platform/graphics/MediaPlayer.cpp:1116 > + if (!containerType.startsWithIgnoringASCIICase("video/") && !containerType.startsWithIgnoringASCIICase("audio/") && !containerType.startsWithIgnoringASCIICase("application/")) Hm, if this is common (I am not sure it is), it makes me wonder if there is a variant of SortedArrayMap to be made that does startsWith() rather than ==.