Bug 239450 - [contain-intrinsic-size] Support contain-intrinsic-size auto && <length>
Summary: [contain-intrinsic-size] Support contain-intrinsic-size auto && <length>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: cathiechen
URL:
Keywords: InRadar
Depends on: 248998
Blocks: 236707 249919
  Show dependency treegraph
 
Reported: 2022-04-17 21:10 PDT by cathiechen
Modified: 2023-02-20 04:48 PST (History)
1 user (show)

See Also:


Attachments
WIP-patch (14.82 KB, patch)
2022-04-18 00:27 PDT, cathiechen
no flags Details | Formatted Diff | Diff
WIP-patch (9.53 KB, patch)
2022-04-18 00:54 PDT, cathiechen
no flags Details | Formatted Diff | Diff
WIP-patch (9.68 KB, patch)
2022-04-29 03:05 PDT, cathiechen
no flags Details | Formatted Diff | Diff
WIP-patch (10.33 KB, patch)
2022-10-31 12:13 PDT, cathiechen
no flags Details | Formatted Diff | Diff
WIP-patch (19.87 KB, patch)
2022-11-23 10:48 PST, cathiechen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description cathiechen 2022-04-17 21:10:13 PDT
Per [1], the last remembers size of contain-intrinsic-size auto && <length> is only effective when content-visibility: auto

[1] https://github.com/w3c/csswg-drafts/issues/6308
Comment 1 cathiechen 2022-04-18 00:27:43 PDT
Created attachment 457796 [details]
WIP-patch
Comment 2 cathiechen 2022-04-18 00:54:09 PDT
Created attachment 457798 [details]
WIP-patch
Comment 3 Radar WebKit Bug Importer 2022-04-24 21:11:13 PDT
<rdar://problem/92246792>
Comment 4 cathiechen 2022-04-29 03:05:04 PDT
Created attachment 458578 [details]
WIP-patch
Comment 5 cathiechen 2022-10-11 07:37:01 PDT
(In reply to cathiechen from comment #0)
> Per [1], the last remembers size of contain-intrinsic-size auto && <length>
> is only effective when content-visibility: auto
> 
> [1] https://github.com/w3c/csswg-drafts/issues/6308

Update the conclusion:

> Drop the "not relevant to the user" condition

Now, the condition is "currently skipping its contents", so it would work for both content-visibility: auto and content-visibility: hidden.
Comment 6 cathiechen 2022-10-31 12:13:58 PDT
Created attachment 463327 [details]
WIP-patch
Comment 7 cathiechen 2022-11-23 10:48:48 PST
Created attachment 463694 [details]
WIP-patch
Comment 8 cathiechen 2022-12-18 12:04:42 PST
Pull request: https://github.com/WebKit/WebKit/pull/7829
Comment 9 EWS 2023-02-20 04:48:21 PST
Committed 260535@main (88587e7bd545): <https://commits.webkit.org/260535@main>

Reviewed commits have been landed. Closing PR #7829 and removing active labels.