Bug 23944 - KURLGoogle's pre-parsed canonicalSpec constructor should take a CString
Summary: KURLGoogle's pre-parsed canonicalSpec constructor should take a CString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-12 22:44 PST by Darin Fisher (:fishd, Google)
Modified: 2009-02-13 11:01 PST (History)
0 users

See Also:


Attachments
v1 patch (6.23 KB, patch)
2009-02-12 22:52 PST, Darin Fisher (:fishd, Google)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-02-12 22:44:18 PST
KURLGoogle's pre-parsed canonicalSpec constructor should take a CString

Internally it allocates a CString, so this would not be a significant change for any existing code.  This change would allow us to efficiently copy from KURL -> CString -> KURL since CString is internally reference counted.  I plan to leverage this in our WebKit layer.
Comment 1 Darin Fisher (:fishd, Google) 2009-02-12 22:52:32 PST
Created attachment 27643 [details]
v1 patch

This patch was already reviewed by Brett Wilson (the author of KURLGoogle) here:
http://codereview.chromium.org/21343
Comment 2 Eric Seidel (no email) 2009-02-12 23:50:08 PST
Comment on attachment 27643 [details]
v1 patch

Looks fine to me.  I much prefer CString over char* + len anyway!
Comment 3 Darin Fisher (:fishd, Google) 2009-02-13 11:01:58 PST
http://trac.webkit.org/changeset/40981