Bug 239431 - Make release assertion in Document::updateLayout more precise for FrameSelection::setSelection
Summary: Make release assertion in Document::updateLayout more precise for FrameSelect...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on: 239520
Blocks:
  Show dependency treegraph
 
Reported: 2022-04-16 23:37 PDT by Ryosuke Niwa
Modified: 2022-05-03 11:15 PDT (History)
5 users (show)

See Also:


Attachments
Patch for landing (23.32 KB, patch)
2022-04-16 23:41 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2022-04-16 23:37:00 PDT
Introduce a new mechanism to denote that layout is up-to-date so that
the release assertion in Document::updateLayout can allow such a construct
even when ScriptDisallowedScope exists.

This will be used in FrameSelection::setSelection for now.
Comment 1 Ryosuke Niwa 2022-04-16 23:41:18 PDT
Created attachment 457766 [details]
Patch for landing
Comment 2 Ryosuke Niwa 2022-04-16 23:41:37 PDT
<rdar://problem/90482211>
Comment 3 Ryosuke Niwa 2022-04-17 01:08:05 PDT
Committed r292947 (?): <https://commits.webkit.org/r292947>
Comment 4 Ryosuke Niwa 2022-04-17 01:08:12 PDT
Comment on attachment 457766 [details]
Patch for landing

Sigh... CQ is taking forever here.
Comment 5 Ryosuke Niwa 2022-04-17 01:08:57 PDT
https://commits.webkit.org/249712@main
Comment 6 WebKit Commit Bot 2022-04-19 14:59:55 PDT
Re-opened since this is blocked by bug 239520