Bug 239415 - Fix duplicate headers warning in libwebrtc Copy Headers phase
Summary: Fix duplicate headers warning in libwebrtc Copy Headers phase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-15 23:32 PDT by Tim Horton
Modified: 2022-04-25 14:25 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.96 KB, patch)
2022-04-15 23:33 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2022-04-15 23:32:35 PDT
Fix duplicate headers warning in libwebrtc Copy Headers phase
Comment 1 Tim Horton 2022-04-15 23:33:05 PDT
Created attachment 457743 [details]
Patch
Comment 2 Tim Horton 2022-04-15 23:34:04 PDT
(I don't actually understand the ownership of these files -- are they imported like the rest of libwebrtc? Will these changes persist?)
Comment 3 Radar WebKit Bug Importer 2022-04-22 23:33:13 PDT
<rdar://problem/92207078>
Comment 4 Elliott Williams 2022-04-25 11:43:23 PDT
Looks good, r=me.

(In reply to Tim Horton from comment #2)
> (I don't actually understand the ownership of these files -- are they
> imported like the rest of libwebrtc? Will these changes persist?)

These file references were added in a somewhat-painstaking manual process as part of the XCBuild migration. I'm guessing they got duplicated due to merge conflict fallout or me dragging and dropping them somewhere weird. I'd be surprised if Xcode is at fault and the change doesn't persist.
Comment 5 Tim Horton 2022-04-25 12:23:42 PDT
(In reply to Elliott Williams from comment #4)
> Looks good, r=me.
> 
> (In reply to Tim Horton from comment #2)
> > (I don't actually understand the ownership of these files -- are they
> > imported like the rest of libwebrtc? Will these changes persist?)
> 
> These file references were added in a somewhat-painstaking manual process as
> part of the XCBuild migration. I'm guessing they got duplicated due to merge
> conflict fallout or me dragging and dropping them somewhere weird. I'd be
> surprised if Xcode is at fault and the change doesn't persist.

Not the ownership I meant -- I meant "does WebKit own these or do they get imported from some external project (see "ThirdParty"). But I think we maybe do own them?
Comment 6 EWS 2022-04-25 13:10:28 PDT
Committed r293341 (249962@main): <https://commits.webkit.org/249962@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457743 [details].
Comment 7 Elliott Williams 2022-04-25 14:25:01 PDT
(In reply to Tim Horton from comment #5) 
> Not the ownership I meant -- I meant "does WebKit own these or do they get
> imported from some external project (see "ThirdParty"). But I think we maybe
> do own them?

Ah, yeah. I believe we own the Xcode project file and have never attempted to upstream changes to it.