Bug 239415 – Fix duplicate headers warning in libwebrtc Copy Headers phase

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Fix duplicate headers warning in libwebrtc Copy Headers phase

[Tim Horton]

Created attachment 457743 [details]
Patch

[Tim Horton]

(I don't actually understand the ownership of these files -- are they imported like the rest of libwebrtc? Will these changes persist?)

[Radar WebKit Bug Importer]

<rdar://problem/92207078>

[Elliott Williams]

Looks good, r=me.

(In reply to Tim Horton from comment #2)
> (I don't actually understand the ownership of these files -- are they
> imported like the rest of libwebrtc? Will these changes persist?)

These file references were added in a somewhat-painstaking manual process as part of the XCBuild migration. I'm guessing they got duplicated due to merge conflict fallout or me dragging and dropping them somewhere weird. I'd be surprised if Xcode is at fault and the change doesn't persist.

[Tim Horton]

(In reply to Elliott Williams from comment #4)
> Looks good, r=me.
> 
> (In reply to Tim Horton from comment #2)
> > (I don't actually understand the ownership of these files -- are they
> > imported like the rest of libwebrtc? Will these changes persist?)
> 
> These file references were added in a somewhat-painstaking manual process as
> part of the XCBuild migration. I'm guessing they got duplicated due to merge
> conflict fallout or me dragging and dropping them somewhere weird. I'd be
> surprised if Xcode is at fault and the change doesn't persist.

Not the ownership I meant -- I meant "does WebKit own these or do they get imported from some external project (see "ThirdParty"). But I think we maybe do own them?

[EWS]

Committed r293341 (249962@main): <https://commits.webkit.org/249962@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457743 [details].

[Elliott Williams]

(In reply to Tim Horton from comment #5) 
> Not the ownership I meant -- I meant "does WebKit own these or do they get
> imported from some external project (see "ThirdParty"). But I think we maybe
> do own them?

Ah, yeah. I believe we own the Xcode project file and have never attempted to upstream changes to it.