Bug 239401 – Use ProcessTerminationReason::Unresponsive for unresponsive network processes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Simon Fraser (smfr)]

Use ProcessTerminationReason::Unresponsive for unresponsive network processes

[Simon Fraser (smfr)]

Created attachment 457719 [details]
Patch

[Chris Dumez]

Comment on attachment 457719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457719&action=review

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:166
>                  weakThis->terminate();

Seems like it would be less error-prone to have an ProcessTerminationReason = ProcessTerminationReason::RequestedByClient optional parameter on terminate(), rather than relying on the call site to call networkProcessDidTerminate() by itself.

[Simon Fraser (smfr)]

(In reply to Chris Dumez from comment #2)
> Comment on attachment 457719 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457719&action=review
> 
> > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:166
> >                  weakThis->terminate();
> 
> Seems like it would be less error-prone to have an ProcessTerminationReason
> = ProcessTerminationReason::RequestedByClient optional parameter on
> terminate(), rather than relying on the call site to call
> networkProcessDidTerminate() by itself.

I considered that, but terminate() is virtual in AuxiliaryProcess so I'd have to change all of them, and the others use the pattern I followed here.

[Simon Fraser (smfr)]

Comment on attachment 457719 [details]
Patch

Breaks some tests because terminate() needs to trigger logging.

[Simon Fraser (smfr)]

Created attachment 457815 [details]
Patch

[EWS]

Committed r293017 (249756@main): <https://commits.webkit.org/249756@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457815 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91963662>