WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
239396
[PGO] Fix build on intel machines
https://bugs.webkit.org/show_bug.cgi?id=239396
Summary
[PGO] Fix build on intel machines
Justin Michaud
Reported
2022-04-15 11:33:31 PDT
For some reason this was never an issue on AS, but we should use the correct operator for string comparison.
Attachments
Add attachment
proposed patch, testcase, etc.
Justin Michaud
Comment 1
2022-04-15 11:37:21 PDT
Argument "ON" isn't numeric in numeric eq (==) at ../../Tools/Scripts/check-for-weak-vtables-and-externals line 63. Use of uninitialized value $ENV{"ENABLE_LLVM_PROFILE_GENERATION"} in numeric eq (==) at ../../Tools/Scripts/check-for-weak-vtables-and-externals line 63.
Justin Michaud
Comment 2
2022-04-15 16:29:40 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/299
EWS
Comment 3
2022-04-18 11:47:35 PDT
Committed
r292962
(
249727@main
): <
https://commits.webkit.org/249727@main
> Reviewed commits have been landed. Closing PR #299 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2022-04-18 11:48:16 PDT
<
rdar://problem/91907374
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug