Bug 239393 - Apply purifyNaN in more places.
Summary: Apply purifyNaN in more places.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-15 11:09 PDT by Mark Lam
Modified: 2022-04-15 12:55 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch. (2.79 KB, patch)
2022-04-15 11:15 PDT, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
patch for landing. (2.72 KB, patch)
2022-04-15 12:14 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-04-15 11:09:40 PDT 
<rdar://problem/91761362>
Comment 1 Mark Lam 2022-04-15 11:15:58 PDT 
Created attachment 457707 [details]
proposed patch.
Comment 2 Saam Barati 2022-04-15 12:03:19 PDT 
Comment on attachment 457707 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=457707&action=review

> Source/JavaScriptCore/wasm/WasmInstance.h:137
> +    double loadF64Global(unsigned i) const { return purifyNaN(bitwise_cast<double>(loadI64Global(i))); }

let's just delete this function?
Comment 3 Mark Lam 2022-04-15 12:14:59 PDT 
Created attachment 457712 [details]
patch for landing.
Comment 4 Mark Lam 2022-04-15 12:55:33 PDT 
Thanks for the review.  Landed in r292920: <http://trac.webkit.org/r292920>.