Bug 239387 – [GStreamer] REGRESSION(r285586): we never end the playback of some videos

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Yacine Bandou]

Since https://commits.webkit.org/r285586 we ignore the EOS message with some videos like this one:

https://www.tv5mondeplus.com/bumpers/tv5_bumper.mp4

[Yacine Bandou]

Created attachment 457703 [details]
Patch

[Philippe Normand]

Comment on attachment 457703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457703&action=review

> Source/WebCore/ChangeLog:3
> +        [GStreamer] REGRESSION(r285586): we never end the playback of some videos

That seems bad :( I wonder how this wasn't detected earlier with layout tests

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1787
> +            GRefPtr<GstPad> SinkPad = adoptGRef(gst_element_get_static_pad(m_videoSink.get(), "sink"));

auto sinkPad = ...

local variables should not begin with a capital letter

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1792
> +            GRefPtr<GstPad> SinkPad = adoptGRef(gst_element_get_static_pad(m_audioSink.get(), "sink"));

ditto

[Yacine Bandou]

(In reply to Philippe Normand from comment #2)
> Comment on attachment 457703 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457703&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [GStreamer] REGRESSION(r285586): we never end the playback of some videos
> 
> That seems bad :( I wonder how this wasn't detected earlier with layout tests
> 

This issue is seen on some MP4 videos that have an inaccurate duration in the mvhd box.

[Yacine Bandou]

Created attachment 457908 [details]
Patch

[Philippe Normand]

Comment on attachment 457908 [details]
Patch

Thanks for providing a test :)

[EWS]

/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Philippe Normand]

Comment on attachment 457908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457908&action=review

> Source/WebCore/ChangeLog:5
> +

https://webkit.org/contributing-code/#changelog-files

[Yacine Bandou]

Created attachment 457976 [details]
Patch

[EWS]

Committed r293091 (249802@main): <https://commits.webkit.org/249802@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457976 [details].

[Radar WebKit Bug Importer]

<rdar://problem/92022235>