Use the ProcessTerminationReason enum for all the process types

[Simon Fraser (smfr)]

Use the ProcessTerminationReason enum for all the process types

[Simon Fraser (smfr)]

Created attachment 457670 [details]
Patch

[Chris Dumez]

Comment on attachment 457670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457670&action=review

> Source/WebKit/Shared/ProcessTerminationReason.cpp:55
> +

ASSERT_NOT_REACHED() ?

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:429
> +        RELEASE_LOG_ERROR(Process, "%p - GPUProcessProxy::gpuProcessExited: reason=%s", this, processTerminationReasonToString(reason));

Needs to be %{public}s or we won't see the reason on production builds.

> Source/WebKit/UIProcess/WebProcessPool.cpp:476
> +    WEBPROCESSPOOL_RELEASE_LOG(Process, "gpuProcessDidExit: PID=%d, reason=%s", identifier, processTerminationReasonToString(reason));

Needs to be %{public}s or we won't see the reason on production builds.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/292912/webkit

[Radar WebKit Bug Importer]

<rdar://problem/91814862>

[Alex Christensen]

Comment on attachment 457670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457670&action=review

> Source/WebKit/Shared/ProcessTerminationReason.cpp:56
> +    return "";

"Invalid"?