Bug 23936 - Tests broken on TOT from added CSS properties and SVG tweaks
Summary: Tests broken on TOT from added CSS properties and SVG tweaks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-12 16:07 PST by Chris Marrin
Modified: 2009-02-13 08:33 PST (History)
0 users

See Also:

Attachments
Patch (85.60 KB, patch)
2009-02-12 16:10 PST, Chris Marrin 		aroben: review-
Details | Formatted Diff | Diff
Patch fixing 2 more test cases (3.10 KB, patch)
2009-02-12 16:47 PST, Chris Marrin 		simon.fraser: review+
Details | Formatted Diff | Diff
Patch fixing 2 windows specific test cases (3.01 KB, patch)
2009-02-13 08:03 PST, Chris Marrin 		no flags Details | Formatted Diff | Diff
Added on more result to this patch (now 3 tests fixed) (7.14 KB, patch)
2009-02-13 08:15 PST, Chris Marrin 		aroben: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2009-02-12 16:07:54 PST 
These are the computed style tests which are now reporting new properties. There is also one SVG test failing pixel test because of the TransformationMatrix changes.
Comment 1 Chris Marrin 2009-02-12 16:10:33 PST 
Created attachment 27628 [details]
Patch
Comment 2 Simon Fraser (smfr) 2009-02-12 16:13:16 PST 
Comment on attachment 27628 [details]
Patch


> +-webkit-dashboard-region: null;

> +    -webkit-dashboard-region: null

These are not your fault and they look wrong; remove them.
r=me with that change.
Comment 3 Adam Roben (:aroben) 2009-02-12 16:19:51 PST 
Comment on attachment 27628 [details]
Patch

Chris, you need to update the three versions of these computed-style results: fast/css, platform/mac/fast/css, and platform/win/fast/css
Comment 4 Chris Marrin 2009-02-12 16:47:30 PST 
Created attachment 27629 [details]
Patch fixing 2 more test cases
Comment 5 Chris Marrin 2009-02-13 07:54:00 PST 
Sending        LayoutTests/ChangeLog
Sending        LayoutTests/platform/mac/fast/css/computed-style-expected.txt
Sending        LayoutTests/platform/mac/fast/css/computed-style-without-renderer-expected.txt
Transmitting file data ...
Committed revision 40974.
Comment 6 Chris Marrin 2009-02-13 07:55:34 PST 
Sending        LayoutTests/ChangeLog
Sending        LayoutTests/fast/css/computed-style-expected.txt
Sending        LayoutTests/fast/css/computed-style-without-renderer-expected.txt
Sending        LayoutTests/fast/dom/Window/window-properties-expected.txt
Sending        LayoutTests/platform/mac/svg/text/text-text-05-t-expected.checksum
Sending        LayoutTests/platform/mac/svg/text/text-text-05-t-expected.png
Transmitting file data ......
Committed revision 40949.
Comment 7 Chris Marrin 2009-02-13 08:03:30 PST 
Created attachment 27660 [details]
Patch fixing 2 windows specific test cases
Comment 8 Chris Marrin 2009-02-13 08:15:20 PST 
Created attachment 27661 [details]
Added on more result to this patch (now 3 tests fixed)
Comment 9 Adam Roben (:aroben) 2009-02-13 08:19:39 PST 
Comment on attachment 27661 [details]
Added on more result to this patch (now 3 tests fixed)

Looks great!

r=me
Comment 10 Chris Marrin 2009-02-13 08:30:58 PST 
Sending        LayoutTests/ChangeLog
Sending        LayoutTests/platform/win/fast/css/computed-style-expected.txt
Sending        LayoutTests/platform/win/fast/css/computed-style-without-renderer-expected.txt
Sending        LayoutTests/svg/css/getComputedStyle-basic-expected.txt
Transmitting file data ....
Committed revision 40977.
Comment 11 Chris Marrin 2009-02-13 08:33:50 PST 
LayoutTests now all pass (WRT these issues), so I'm closing this for now. There are tests being skipped, but that is covered by https://bugs.webkit.org/show_bug.cgi?id=23927.