RESOLVED FIXED23936
Tests broken on TOT from added CSS properties and SVG tweaks 
https://bugs.webkit.org/show_bug.cgi?id=23936
Summary Tests broken on TOT from added CSS properties and SVG tweaks
Chris Marrin
Reported 2009-02-12 16:07:54 PST
These are the computed style tests which are now reporting new properties. There is also one SVG test failing pixel test because of the TransformationMatrix changes.
Attachments
Patch (85.60 KB, patch)
2009-02-12 16:10 PST, Chris Marrin 		aroben: review-
DetailsFormatted DiffDiff
Patch fixing 2 more test cases (3.10 KB, patch)
2009-02-12 16:47 PST, Chris Marrin 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch fixing 2 windows specific test cases (3.01 KB, patch)
2009-02-13 08:03 PST, Chris Marrin 		no flags
DetailsFormatted DiffDiff
Added on more result to this patch (now 3 tests fixed) (7.14 KB, patch)
2009-02-13 08:15 PST, Chris Marrin 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2009-02-12 16:10:33 PST
Created attachment 27628 [details] Patch
Simon Fraser (smfr)
Comment 2 2009-02-12 16:13:16 PST
Comment on attachment 27628 [details] Patch > +-webkit-dashboard-region: null; > + -webkit-dashboard-region: null These are not your fault and they look wrong; remove them. r=me with that change.
Adam Roben (:aroben)
Comment 3 2009-02-12 16:19:51 PST
Comment on attachment 27628 [details] Patch Chris, you need to update the three versions of these computed-style results: fast/css, platform/mac/fast/css, and platform/win/fast/css
Chris Marrin
Comment 4 2009-02-12 16:47:30 PST
Created attachment 27629 [details] Patch fixing 2 more test cases
Chris Marrin
Comment 5 2009-02-13 07:54:00 PST
Sending LayoutTests/ChangeLog Sending LayoutTests/platform/mac/fast/css/computed-style-expected.txt Sending LayoutTests/platform/mac/fast/css/computed-style-without-renderer-expected.txt Transmitting file data ... Committed revision 40974.
Chris Marrin
Comment 6 2009-02-13 07:55:34 PST
Sending LayoutTests/ChangeLog Sending LayoutTests/fast/css/computed-style-expected.txt Sending LayoutTests/fast/css/computed-style-without-renderer-expected.txt Sending LayoutTests/fast/dom/Window/window-properties-expected.txt Sending LayoutTests/platform/mac/svg/text/text-text-05-t-expected.checksum Sending LayoutTests/platform/mac/svg/text/text-text-05-t-expected.png Transmitting file data ...... Committed revision 40949.
Chris Marrin
Comment 7 2009-02-13 08:03:30 PST
Created attachment 27660 [details] Patch fixing 2 windows specific test cases
Chris Marrin
Comment 8 2009-02-13 08:15:20 PST
Created attachment 27661 [details] Added on more result to this patch (now 3 tests fixed)
Adam Roben (:aroben)
Comment 9 2009-02-13 08:19:39 PST
Comment on attachment 27661 [details] Added on more result to this patch (now 3 tests fixed) Looks great! r=me
Chris Marrin
Comment 10 2009-02-13 08:30:58 PST
Sending LayoutTests/ChangeLog Sending LayoutTests/platform/win/fast/css/computed-style-expected.txt Sending LayoutTests/platform/win/fast/css/computed-style-without-renderer-expected.txt Sending LayoutTests/svg/css/getComputedStyle-basic-expected.txt Transmitting file data .... Committed revision 40977.
Chris Marrin
Comment 11 2009-02-13 08:33:50 PST
LayoutTests now all pass (WRT these issues), so I'm closing this for now. There are tests being skipped, but that is covered by https://bugs.webkit.org/show_bug.cgi?id=23927.
Note You need to log in before you can comment on or make changes to this bug.