RESOLVED FIXED 239351
Undo option after invoking "Markup Image" says "Undo Paste" 
https://bugs.webkit.org/show_bug.cgi?id=239351
Summary Undo option after invoking "Markup Image" says "Undo Paste"
Wenson Hsieh
Reported 2022-04-14 12:48:07 PDT
rdar://91647863
Attachments
Patch (26.73 KB, patch)
2022-04-14 13:03 PDT, Wenson Hsieh 		darin: review+
DetailsFormatted DiffDiff
For landing (28.96 KB, patch)
2022-04-14 16:08 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2022-04-14 13:03:30 PDT
Created attachment 457644 [details] Patch
Darin Adler
Comment 2 2022-04-14 15:22:46 PDT
Comment on attachment 457644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457644&action=review > Source/WebCore/editing/EditAction.h:97 > + Outdent, > + MarkupImage, Looks like this was alphabetical before. Maybe keep it alphabetical?
Wenson Hsieh
Comment 3 2022-04-14 15:28:36 PDT
Comment on attachment 457644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457644&action=review Thanks for the review! >> Source/WebCore/editing/EditAction.h:97 >> + MarkupImage, > > Looks like this was alphabetical before. Maybe keep it alphabetical? Will do!
Wenson Hsieh
Comment 4 2022-04-14 15:32:31 PDT
Comment on attachment 457644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457644&action=review >>> Source/WebCore/editing/EditAction.h:97 >>> + MarkupImage, >> >> Looks like this was alphabetical before. Maybe keep it alphabetical? > > Will do! …since these enums are already unsorted, I'll go ahead and just put them all in sorted order while I'm here.
Darin Adler
Comment 5 2022-04-14 16:05:05 PDT
Ah, only the part that showed up as context in diff was alphabetical! I should have suspected.
Wenson Hsieh
Comment 6 2022-04-14 16:08:45 PDT
Created attachment 457654 [details] For landing
EWS
Comment 7 2022-04-14 18:47:07 PDT
Committed r292898 (249668@main): <https://commits.webkit.org/249668@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457654 [details].
Note You need to log in before you can comment on or make changes to this bug.