Bug 239351 - Undo option after invoking "Markup Image" says "Undo Paste"
Summary: Undo option after invoking "Markup Image" says "Undo Paste"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-14 12:48 PDT by Wenson Hsieh
Modified: 2022-04-14 21:45 PDT (History)
13 users (show)

See Also:

Attachments
Patch (26.73 KB, patch)
2022-04-14 13:03 PDT, Wenson Hsieh 		darin: review+
Details | Formatted Diff | Diff
For landing (28.96 KB, patch)
2022-04-14 16:08 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2022-04-14 12:48:07 PDT 
rdar://91647863
Comment 1 Wenson Hsieh 2022-04-14 13:03:30 PDT 
Created attachment 457644 [details]
Patch
Comment 2 Darin Adler 2022-04-14 15:22:46 PDT 
Comment on attachment 457644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457644&action=review

> Source/WebCore/editing/EditAction.h:97
> +    Outdent,
> +    MarkupImage,

Looks like this was alphabetical before. Maybe keep it alphabetical?
Comment 3 Wenson Hsieh 2022-04-14 15:28:36 PDT 
Comment on attachment 457644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457644&action=review

Thanks for the review!

>> Source/WebCore/editing/EditAction.h:97
>> +    MarkupImage,
> 
> Looks like this was alphabetical before. Maybe keep it alphabetical?

Will do!
Comment 4 Wenson Hsieh 2022-04-14 15:32:31 PDT 
Comment on attachment 457644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457644&action=review

>>> Source/WebCore/editing/EditAction.h:97
>>> +    MarkupImage,
>> 
>> Looks like this was alphabetical before. Maybe keep it alphabetical?
> 
> Will do!

…since these enums are already unsorted, I'll go ahead and just put them all in sorted order while I'm here.
Comment 5 Darin Adler 2022-04-14 16:05:05 PDT 
Ah, only the part that showed up as context in diff was alphabetical! I should have suspected.
Comment 6 Wenson Hsieh 2022-04-14 16:08:45 PDT 
Created attachment 457654 [details]
For landing
Comment 7 EWS 2022-04-14 18:47:07 PDT 
Committed r292898 (249668@main): <https://commits.webkit.org/249668@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457654 [details].