Bug 239346 – InternalFunction::createSubclassStructure() should use base object's global object

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Alexey Shvayka]

InternalFunction::createSubclassStructure() should use base object's global object

[Alexey Shvayka]

Created attachment 457640 [details]
Patch

[Darin Adler]

Comment on attachment 457640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457640&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        Chrome and Firefox don't agree on interoperable behavior in case of cross-realm
> +        NewTarget's "prototype", so this patch aligns WebKit with Chrome to fix a web-compat issue.

In future: Where should the interoperability test go? WPT? Somewhere else?

[Alexey Shvayka]

Committed r292883 (249653@trunk): <https://commits.webkit.org/249653@trunk>

[Radar WebKit Bug Importer]

<rdar://problem/91770382>

[Alexey Shvayka]

(In reply to Darin Adler from comment #2)
> Comment on attachment 457640 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457640&action=review
> 
> > Source/JavaScriptCore/ChangeLog:9
> > +        Chrome and Firefox don't agree on interoperable behavior in case of cross-realm
> > +        NewTarget's "prototype", so this patch aligns WebKit with Chrome to fix a web-compat issue.
> 
> In future: Where should the interoperability test go? WPT? Somewhere else?

Discussed this with Darin offline.

[Radar WebKit Bug Importer]

<rdar://problem/91770431>

[Alexey Shvayka]

Committed r292886 (249656@trunk): <https://commits.webkit.org/249656@trunk>