Bug 239344 - IGNORE_WARNINGS_BEGIN should not warn about unrecognized warnings
Summary: IGNORE_WARNINGS_BEGIN should not warn about unrecognized warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-14 09:46 PDT by Michael Catanzaro
Modified: 2022-04-15 18:12 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2022-04-14 09:46:13 PDT 
See https://bugs.webkit.org/show_bug.cgi?id=239299#c7, we don't want to warn about unrecognized warnings
Comment 1 Michael Catanzaro 2022-04-14 09:49:02 PDT 
This is only a problem for GCC, because Clang has __has_warning() which we use to drop attempts to suppress unrecognized warnings, and I'm pretty sure Clang doesn't warn about unrecognized pragmas anyway. (The IGNORE_WARNINGS macros are only implemented for GCC and Clang.)
Comment 2 Michael Catanzaro 2022-04-14 09:55:25 PDT 
https://github.com/WebKit/WebKit/pull/291
Comment 3 EWS 2022-04-15 18:11:56 PDT 
Committed r292934 (249699@main): <https://commits.webkit.org/249699@main>

Reviewed commits have been landed. Closing PR #291 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2022-04-15 18:12:15 PDT 
<rdar://problem/91838502>