Bug 23934 - Skia platform doesn't render text decoration shadows
Summary: Skia platform doesn't render text decoration shadows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-12 15:53 PST by Scott Violet
Modified: 2009-02-13 11:06 PST (History)
1 user (show)

See Also:


Attachments
Fix for 23934 (4.88 KB, patch)
2009-02-12 16:00 PST, Scott Violet
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Violet 2009-02-12 15:53:40 PST
This is covered by these layout tests:

LayoutTests/fast/repaint/shadow-multiple-horizontal.html
LayoutTests/fast/repaint/shadow-multiple-strict-horizontal.html
LayoutTests/fast/repaint/shadow-multiple-strict-vertical.html
LayoutTests/fast/repaint/shadow-multiple-vertical.html
Comment 1 Scott Violet 2009-02-12 16:00:05 PST
Created attachment 27625 [details]
Fix for 23934
Comment 2 Eric Seidel (no email) 2009-02-12 16:11:03 PST
Comment on attachment 27625 [details]
Fix for 23934

I don't quite understand why the fill/stroke changes are necessary. I'd also rather they were named something like fillColorWithAlpha() if you're going to pre-multiply the alpha?
Comment 3 Scott Violet 2009-02-12 16:15:49 PST
The alpha is stored separately in PlatformContextSkia. To get the real color to draw with you need to add the alpha into it. See other places in PlatformContextSkia that do the same song and dance.

Brett suggested the name effectiveXXX.
Comment 4 Eric Seidel (no email) 2009-02-12 16:28:31 PST
Comment on attachment 27625 [details]
Fix for 23934

144     // Returns the stroke color. The returned color has it's alpha adjusted
 145     // by the current alpha.

Whoever lands this could change that comment to say "current context alpha" instead of just "current alpha" to be more specific that this is the context-wide alpha which CG supports, thus GraphicsContext supports, and thus we support.

I talked this out with brett at length.  The patch looks fine.
Comment 5 Dimitri Glazkov (Google) 2009-02-13 11:06:17 PST
Landed as http://trac.webkit.org/changeset/40982.