Bug 239335 – Require an existing AtomString for HTMLFormElement's named getter parameter

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Require an existing AtomString for HTMLFormElement's named getter parameter. There is no point in allocating a new AtomString as the AtomString should already exist if there is any element with this name / id.

[Chris Dumez]

Created attachment 457630 [details]
Patch

[Darin Adler]

Comment on attachment 457630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457630&action=review

> Source/WebCore/html/HTMLFormElement.cpp:936
> +    if (name.isEmpty())
> +        return { };

This further optimizes the null and empty string cases, but slows down all the non-empty cases. I don’t think it’s needed for correctness, unless I missed something. I suppose it’s a good idea.

> Source/WebCore/html/HTMLFormElement.idl:42
> +    getter (RadioNodeList or Element)? ([RequiresExistingAtomString] DOMString name);

Want to be sure these are good optimizations. I think I made RequiresExistingAtomString, and it’s obviously helpful if people often look for something that doesn’t exist, but it might *slightly* slow down the case of looking for things that do exist.

[EWS]

Committed r292887 (249657@main): <https://commits.webkit.org/249657@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457630 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91774265>