Bug 239320 – [iOS] Add support for find-and-replace keyboard shortcut

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Aditya Keerthi]

...

[Aditya Keerthi]

rdar://91537724

[Aditya Keerthi]

Created attachment 457592 [details]
Patch

[Aditya Keerthi]

Comment on attachment 457592 [details]
Patch

Thanks for the review!

[EWS]

Committed r292880 (249650@main): <https://commits.webkit.org/249650@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457592 [details].

[Darin Adler]

Comment on attachment 457592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457592&action=review

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:136
>  - (void)find:(id)sender;
>  - (void)findNext:(id)sender;
>  - (void)findPrevious:(id)sender;
> +- (void)findAndReplace:(id)sender;

Should these be public API with availability annotations? I don’t understand why they are still internal.

[Aditya Keerthi]

(In reply to Darin Adler from comment #5)
> Comment on attachment 457592 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457592&action=review
> 
> > Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:136
> >  - (void)find:(id)sender;
> >  - (void)findNext:(id)sender;
> >  - (void)findPrevious:(id)sender;
> > +- (void)findAndReplace:(id)sender;
> 
> Should these be public API with availability annotations? I don’t understand
> why they are still internal.

Good question!

These methods are specifically for editing shortcuts / menu items through the UIKit protocol  `UIResponderStandardEditActions`. They are currently in a private UIKit header, and are declared here for use in WebKit. Once they are moved to a public header, we will no longer declare them here.

Note that `WKWebView` does not publicly conform to `UIResponderStandardEditActions` at this time. This is a historical artifact, and there's not a good reason for keeping it that away. I've filed https://bugs.webkit.org/show_bug.cgi?id=239349 to make conformance to UIKit's protocol public.

The actual functionality of these methods (being able to find/replace) will be API through `findInteraction`. This is independent of public conformance to `UIResponderStandardEditActions`, which is specifically for editing shortcuts / menu items.