Bug 239301 - [Xcode] Fix public watchOS workspace build by updating scheme and build settings
Summary: [Xcode] Fix public watchOS workspace build by updating scheme and build settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-13 13:56 PDT by Elliott Williams
Modified: 2022-04-13 17:17 PDT (History)
6 users (show)

See Also:

Attachments
Patch (8.33 KB, patch)
2022-04-13 14:02 PDT, Elliott Williams 		no flags Details | Formatted Diff | Diff
Patch (13.14 KB, patch)
2022-04-13 15:00 PDT, Elliott Williams 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-04-13 13:56:34 PDT 
[Xcode] Fix public watchOS workspace build by updating scheme and build settings
Comment 1 Elliott Williams 2022-04-13 14:02:30 PDT 
Created attachment 457567 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-04-13 14:07:29 PDT 
<rdar://problem/91713730>
Comment 3 Alexey Proskuryakov 2022-04-13 14:23:14 PDT 
Comment on attachment 457567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457567&action=review

> WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:-51
> -         <BuildActionEntry

Not clear to me what these changes are doing, and the patch lacks a ChangeLog.
Comment 4 Elliott Williams 2022-04-13 15:00:55 PDT 
Created attachment 457568 [details]
Patch
Comment 5 Elliott Williams 2022-04-13 15:01:41 PDT 
(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 457567 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457567&action=review
> 
> > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:-51
> > -         <BuildActionEntry
> 
> Not clear to me what these changes are doing, and the patch lacks a
> ChangeLog.

Bad patch, sorry about that. Let me know if there's anything else I can clarify wrt the scheme changes.
Comment 6 Alexey Proskuryakov 2022-04-13 15:23:59 PDT 
Comment on attachment 457568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457568&action=review

> ChangeLog:19
> +        - Remove MiniBrowser from the "All Source" scheme, as it's part of "All
> +        Tools". "All Tools" probably shouldn't be built for embedded

This seems controversial. Engineers use MiniBrowser for testing during iteration, so there should be a one-step way to build WebKit and MiniBrowser at once.
Comment 7 Elliott Williams 2022-04-13 16:40:42 PDT 
(In reply to Alexey Proskuryakov from comment #6)
> Comment on attachment 457568 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457568&action=review
> 
> > ChangeLog:19
> > +        - Remove MiniBrowser from the "All Source" scheme, as it's part of "All
> > +        Tools". "All Tools" probably shouldn't be built for embedded
> 
> This seems controversial. Engineers use MiniBrowser for testing during
> iteration, so there should be a one-step way to build WebKit and MiniBrowser
> at once.

The way you'd do that is by building the MiniBrowser scheme, which will build the stack up to MiniBrowser, including WebKit.

And if an engineer wanted to build the entire repo (like EWS does), they'd build "All Modules", which is intended to be equivalent to running `make` from the top-level directory.
Comment 8 EWS 2022-04-13 17:17:05 PDT 
Committed r292845 (249618@main): <https://commits.webkit.org/249618@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457568 [details].