Bug 23928 - Fix run-webkit-tests to skip some dirs when new features are turned off
Summary: Fix run-webkit-tests to skip some dirs when new features are turned off
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Enhancement
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 23359
  Show dependency treegraph
 
Reported: 2009-02-12 10:30 PST by Simon Fraser (smfr)
Modified: 2009-02-12 14:30 PST (History)
1 user (show)

See Also:


Attachments
Patch, changelog (3.47 KB, patch)
2009-02-12 11:41 PST, Simon Fraser (smfr)
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-02-12 10:30:24 PST
It should be possible for run-webkit-tests to run additional tests to test features that are inside of #ifdefs, without the user having to specify additional directories manually.

As is done for SVG, this can be done by using 'nm' to detect if the feature is turned on (by looking for a unique symbol), and then looking for specific test directories.
Comment 1 Simon Fraser (smfr) 2009-02-12 11:41:59 PST
Created attachment 27615 [details]
Patch, changelog
Comment 2 Adam Roben (:aroben) 2009-02-12 13:04:00 PST
Comment on attachment 27615 [details]
Patch, changelog

> +if (!checkWebCoreAcceleratedCompositingSupport(0)) {
> +    $ignoredDirectories{'compositing'} = 1;
> +}

I guess this is the style already used by SVG/WML, but I think something like this would be clearer:

if (!checkWebCoreAcceleratedCompositingSupport({required => 0})) {

r=me
Comment 3 Simon Fraser (smfr) 2009-02-12 14:30:57 PST
http://trac.webkit.org/changeset/40927