RESOLVED FIXED 239268
[WinCairo] WEBKIT_LIBRARIES env var should be customizable 
https://bugs.webkit.org/show_bug.cgi?id=239268
Summary [WinCairo] WEBKIT_LIBRARIES env var should be customizable
Fujii Hironori
Reported 2022-04-12 17:43:52 PDT
Even though WEBKIT_LIBRARIES is a env var, it isn't customizable. It should set to WebKitLibraries\win directory for WinCairo builds. > set WEBKIT_LIBRARIES=%~dp0WebKitLibraries\win This has two problems: 1. It is the same directory with one AppleWin is using. This is error prone. See Bug 238988. 2. WebKitLibraries\win directory is a source directory. It isn't a good practise to overwrite source directories. I'd like to set it to a WinCairo specific directory for me. For example, > set WEBKIT_LIBRARIES=%~dp0WinCairoLibraries As for now, if I change the env var, the build fails. auto-version.pl is missing.
Attachments
Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-04-12 20:38:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/280
EWS
Comment 2 2022-04-13 13:06:20 PDT
Committed r292824 (249600@main): <https://commits.webkit.org/249600@main> Reviewed commits have been landed. Closing PR #280 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-04-13 13:07:15 PDT
<rdar://problem/91709965>
Note You need to log in before you can comment on or make changes to this bug.