Bug 23920 - build script doesn't respect setting installation prefix
Summary: build script doesn't respect setting installation prefix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2009-02-12 07:34 PST by Gustavo Noronha (kov)
Modified: 2009-02-16 19:15 PST (History)
0 users

See Also:

Attachments
proposed fix (1.47 KB, patch)
2009-02-12 07:36 PST, Gustavo Noronha (kov) 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2009-02-12 07:34:29 PST 
The script used to build WebKit expects a WebKitInstallationPrefix environment variable to exist, which should be used to set the installation prefix for autotools builds. The setting is currently being ignored, though.
Comment 1 Gustavo Noronha (kov) 2009-02-12 07:36:29 PST 
Created attachment 27602 [details]
proposed fix
Comment 2 Adam Roben (:aroben) 2009-02-12 07:38:33 PST 
Comment on attachment 27602 [details]
proposed fix

> +    push @buildArgs, "--prefix=" . $prefix if(defined($prefix));

We normally leave out the parentheses around the condition in these postfix ifs:

push @buildArgs, "--prefix=" . $prefix if defined($prefix);

r=me
Comment 3 Gustavo Noronha (kov) 2009-02-16 19:15:30 PST 
Landed in r41033.