Bug 23915 - Remove setPrefix work-around in Document::createElement(QualifiedName, bool)
Summary: Remove setPrefix work-around in Document::createElement(QualifiedName, bool)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-11 21:52 PST by Julien Chaffraix
Modified: 2009-02-12 12:53 PST (History)
0 users

See Also:

Attachments
Proposed fix: propage the qualifiedName (7.83 KB, patch)
2009-02-11 22:38 PST, Julien Chaffraix 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2009-02-11 21:52:58 PST 
Now that the Factory can pass the QualifiedName to the Element, it is not required and should be replaced with this alternative. Patch forthcoming.
Comment 1 Julien Chaffraix 2009-02-11 22:38:45 PST 
Created attachment 27587 [details]
Proposed fix: propage the qualifiedName
Comment 2 Darin Adler 2009-02-12 09:44:34 PST 
Comment on attachment 27587 [details]
Proposed fix: propage the qualifiedName

> +    UNUSED_PARAM(ec); // FIXME: To be removed.

UNUSED_PARAM should only be used as a last resort. Here you can just remove the parameter name "ec" from the function arguments list in the function definition instead.

> +                debug("FAILED: localName does not matche <img>");

There's an extra "e" here.

Please remove that unused ExceptionCode argument as soon as possible!

r=me
Comment 3 Julien Chaffraix 2009-02-12 12:53:53 PST 
Committed addressing both issues in r40924.