WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
23915
Remove setPrefix work-around in Document::createElement(QualifiedName, bool)
https://bugs.webkit.org/show_bug.cgi?id=23915
Summary
Remove setPrefix work-around in Document::createElement(QualifiedName, bool)
Julien Chaffraix
Reported
2009-02-11 21:52:58 PST
Now that the Factory can pass the QualifiedName to the Element, it is not required and should be replaced with this alternative. Patch forthcoming.
Attachments
Proposed fix: propage the qualifiedName
(7.83 KB, patch)
2009-02-11 22:38 PST
,
Julien Chaffraix
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Julien Chaffraix
Comment 1
2009-02-11 22:38:45 PST
Created
attachment 27587
[details]
Proposed fix: propage the qualifiedName
Darin Adler
Comment 2
2009-02-12 09:44:34 PST
Comment on
attachment 27587
[details]
Proposed fix: propage the qualifiedName
> + UNUSED_PARAM(ec); // FIXME: To be removed.
UNUSED_PARAM should only be used as a last resort. Here you can just remove the parameter name "ec" from the function arguments list in the function definition instead.
> + debug("FAILED: localName does not matche <img>");
There's an extra "e" here. Please remove that unused ExceptionCode argument as soon as possible! r=me
Julien Chaffraix
Comment 3
2009-02-12 12:53:53 PST
Committed addressing both issues in
r40924
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug