Bug 239132 - [GTK] Remove WebKitInstallMissingMediaPluginsPermissionRequest
Summary: [GTK] Remove WebKitInstallMissingMediaPluginsPermissionRequest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks: GTK4
  Show dependency treegraph
 
Reported: 2022-04-12 10:40 PDT by Michael Catanzaro
Modified: 2023-01-10 03:11 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2022-04-12 10:40:32 PDT
The WebKitInstallMissingMediaPluginsPermissionRequest API has been broken for six years, ever since we fixed bug #135972. Let's remove this from our GTK 4 API.

We might eventually create a new API to handle codec installation, see bug #147822, but I don't think it's terribly urgent or important. Normally you can either offer codecs and install them by default (e.g. Debian), or you can't offer them at all (e.g. Fedora). Having a codec installer that's either not needed or cannot work is not super useful either way.
Comment 1 Michael Catanzaro 2022-09-08 07:57:57 PDT
Note there are D-Bus permissions for this in XDGDBusProxy.cpp that should be removed.

Also we should deprecate the APIs in the old API version, as they haven't been deprecated yet.
Comment 2 Michael Catanzaro 2022-09-08 07:58:28 PDT
Also should remove /webkit2/WebKitWebView/install-missing-plugins-permission-request and any failure expectations.
Comment 3 Philippe Normand 2023-01-05 01:18:01 PST
I agree, I'll prepare a patch for this.
Comment 4 Philippe Normand 2023-01-05 03:01:03 PST
Pull request: https://github.com/WebKit/WebKit/pull/8232
Comment 5 EWS 2023-01-09 01:53:57 PST
Committed 258653@main (209971efaec5): <https://commits.webkit.org/258653@main>

Reviewed commits have been landed. Closing PR #8232 and removing active labels.