Bug 239131 - Add logging for persistent notification event handler failure
Summary: Add logging for persistent notification event handler failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-12 09:56 PDT by youenn fablet
Modified: 2022-04-14 09:26 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.15 KB, patch)
2022-04-12 10:54 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.11 KB, patch)
2022-04-14 08:20 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-04-12 09:56:32 PDT 
Add logging for persistent notification event handler failure
Comment 1 youenn fablet 2022-04-12 10:54:22 PDT 
Created attachment 457347 [details]
Patch
Comment 2 Chris Dumez 2022-04-14 07:20:39 PDT 
Comment on attachment 457347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457347&action=review

> Source/WebCore/workers/service/server/SWServer.cpp:1376
> +                RELEASE_LOG_ERROR_IF(succeeded, ServiceWorker, "Service Worker notification event handler did not succeed");

Shouldn't that be !succeeded ?
Comment 3 youenn fablet 2022-04-14 08:20:03 PDT 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 457347 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457347&action=review
> 
> > Source/WebCore/workers/service/server/SWServer.cpp:1376
> > +                RELEASE_LOG_ERROR_IF(succeeded, ServiceWorker, "Service Worker notification event handler did not succeed");
> 
> Shouldn't that be !succeeded ?

Indeed, fixed!
Comment 4 youenn fablet 2022-04-14 08:20:16 PDT 
Created attachment 457632 [details]
Patch
Comment 5 EWS 2022-04-14 09:25:13 PDT 
Committed r292872 (249643@main): <https://commits.webkit.org/249643@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457632 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-14 09:26:14 PDT 
<rdar://problem/91758050>