Bug 239123 - Complement implementation of step 5.5 of https://fetch.spec.whatwg.org/#http-fetch
Summary: Complement implementation of step 5.5 of https://fetch.spec.whatwg.org/#http-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-12 05:51 PDT by youenn fablet
Modified: 2022-04-13 03:41 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.49 KB, patch)
2022-04-12 05:52 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (10.48 KB, patch)
2022-04-13 01:31 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-04-12 05:51:33 PDT 
Complement implementation of step 5.5 of https://fetch.spec.whatwg.org/#http-fetch
Comment 1 youenn fablet 2022-04-12 05:52:47 PDT 
Created attachment 457328 [details]
Patch
Comment 2 Darin Adler 2022-04-12 12:53:56 PDT 
Comment on attachment 457328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457328&action=review

> Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp:56
> +        return ResourceError { errorDomainWebKitInternal, 0, response.url(), "Response served by service worker is cors while mode is same origin"_s, ResourceError::Type::AccessControl, ResourceError::IsSanitized::Yes };

Should error message say "CORS" instead of "cors"?
Comment 3 youenn fablet 2022-04-13 01:31:52 PDT 
Created attachment 457514 [details]
Patch for landing
Comment 4 youenn fablet 2022-04-13 01:33:33 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 457328 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457328&action=review
> 
> > Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp:56
> > +        return ResourceError { errorDomainWebKitInternal, 0, response.url(), "Response served by service worker is cors while mode is same origin"_s, ResourceError::Type::AccessControl, ResourceError::IsSanitized::Yes };
> 
> Should error message say "CORS" instead of "cors"?

Right, I updated the error message
Comment 5 EWS 2022-04-13 03:40:42 PDT 
Committed r292804 (249586@main): <https://commits.webkit.org/249586@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457514 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-13 03:41:17 PDT 
<rdar://problem/91680481>