Bug 239123 – Complement implementation of step 5.5 of https://fetch.spec.whatwg.org/#http-fetch

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Complement implementation of step 5.5 of https://fetch.spec.whatwg.org/#http-fetch

[youenn fablet]

Created attachment 457328 [details]
Patch

[Darin Adler]

Comment on attachment 457328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457328&action=review

> Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp:56
> +        return ResourceError { errorDomainWebKitInternal, 0, response.url(), "Response served by service worker is cors while mode is same origin"_s, ResourceError::Type::AccessControl, ResourceError::IsSanitized::Yes };

Should error message say "CORS" instead of "cors"?

[youenn fablet]

Created attachment 457514 [details]
Patch for landing

[youenn fablet]

(In reply to Darin Adler from comment #2)
> Comment on attachment 457328 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457328&action=review
> 
> > Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp:56
> > +        return ResourceError { errorDomainWebKitInternal, 0, response.url(), "Response served by service worker is cors while mode is same origin"_s, ResourceError::Type::AccessControl, ResourceError::IsSanitized::Yes };
> 
> Should error message say "CORS" instead of "cors"?

Right, I updated the error message

[EWS]

Committed r292804 (249586@main): <https://commits.webkit.org/249586@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457514 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91680481>