Bug 23912 – REGRESSION: Select elements don't scroll in response to the mouse wheel

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Oliver Hunt]

When attempting to scroll the Component select element on bugzilla i found that the entire page scrolled, rather than just the select contents.

Steps to reproduce:
1. Go to https://bugs.webkit.org/enter_bug.cgi?product=WebKit
2. move mouse over Component select element
3. try to scroll select element with scroll wheel

[Mark Rowe (bdash)]

<rdar://problem/6579560>

[Adele Peterson]

I think this used to work.  I wonder when it regressed.

[Oliver Hunt]

(In reply to comment #2)
> I think this used to work.  I wonder when it regressed.
> 

It worked relatively recently, i'm blaming hyatt's many recent changes, although i have no real basis for this other than my fear of large changes, and, well, it's hyatt ;D

[Adele Peterson]

Yup, works in 3.1.1

[Dave Hyatt]

Created attachment 27616 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 27616 [details]
Patch

> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 40918)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,16 @@
> [phone]  David Hyatt  <[e-mail]>
> +
> +        Fix for https://bugs.webkit.org/show_bug.cgi?id=23912
> +
> +        I have no idea why this broke.  As far as I can tell the old code never should have worked in
> +        the first place.  Add code to handleWheelEvent that will find an enclosing renderer for a node
> +        in order to attempt a wheel scroll.
> +
> +        Reviewed by NOBODY (OOPS!).

"Reviewed by" should go at the top. r-me.

[Dave Hyatt]

Fixed in r40919.  It bugs me that I have no idea what change broke this or why it ever worked in the first place.