Bug 23912 - REGRESSION: Select elements don't scroll in response to the mouse wheel
Summary: REGRESSION: Select elements don't scroll in response to the mouse wheel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P1 Normal
Assignee: Dave Hyatt
URL: https://bugs.webkit.org/enter_bug.cgi...
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2009-02-11 20:54 PST by Oliver Hunt
Modified: 2009-02-12 12:19 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.83 KB, patch)
2009-02-12 12:13 PST, Dave Hyatt
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-02-11 20:54:41 PST
When attempting to scroll the Component select element on bugzilla i found that the entire page scrolled, rather than just the select contents.

Steps to reproduce:
1. Go to https://bugs.webkit.org/enter_bug.cgi?product=WebKit
2. move mouse over Component select element
3. try to scroll select element with scroll wheel
Comment 1 Mark Rowe (bdash) 2009-02-11 20:55:46 PST
<rdar://problem/6579560>
Comment 2 Adele Peterson 2009-02-11 20:57:22 PST
I think this used to work.  I wonder when it regressed.
Comment 3 Oliver Hunt 2009-02-11 21:00:26 PST
(In reply to comment #2)
> I think this used to work.  I wonder when it regressed.
> 

It worked relatively recently, i'm blaming hyatt's many recent changes, although i have no real basis for this other than my fear of large changes, and, well, it's hyatt ;D
Comment 4 Adele Peterson 2009-02-11 21:00:42 PST
Yup, works in 3.1.1
Comment 5 Dave Hyatt 2009-02-12 12:13:47 PST
Created attachment 27616 [details]
Patch
Comment 6 Simon Fraser (smfr) 2009-02-12 12:15:41 PST
Comment on attachment 27616 [details]
Patch

> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 40918)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,16 @@
> +2009-02-12  David Hyatt  <hyatt@apple.com>
> +
> +        Fix for https://bugs.webkit.org/show_bug.cgi?id=23912
> +
> +        I have no idea why this broke.  As far as I can tell the old code never should have worked in
> +        the first place.  Add code to handleWheelEvent that will find an enclosing renderer for a node
> +        in order to attempt a wheel scroll.
> +
> +        Reviewed by NOBODY (OOPS!).

"Reviewed by" should go at the top. r-me.
Comment 7 Dave Hyatt 2009-02-12 12:19:11 PST
Fixed in r40919.  It bugs me that I have no idea what change broke this or why it ever worked in the first place.