Bug 239098 - Fix PlayStation build after r292696
Summary: Fix PlayStation build after r292696
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-11 17:44 PDT by Don Olmstead
Modified: 2022-04-12 11:53 PDT (History)
6 users (show)

See Also:

Attachments
[fast-cq] Patch (2.38 KB, patch)
2022-04-11 17:55 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2022-04-11 17:44:11 PDT 
...
Comment 1 Don Olmstead 2022-04-11 17:55:56 PDT 
Created attachment 457304 [details]
[fast-cq] Patch
Comment 2 EWS 2022-04-11 18:33:55 PDT 
Committed r292753 (249537@main): <https://commits.webkit.org/249537@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457304 [details].
Comment 3 Radar WebKit Bug Importer 2022-04-11 18:34:15 PDT 
<rdar://problem/91601084>
Comment 4 Darin Adler 2022-04-12 11:37:03 PDT 
Comment on attachment 457304 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457304&action=review

> Source/WebDriver/playstation/WebDriverServicePlayStation.cpp:48
> +    capabilities.platformName = String::fromLatin1("playstation");

The preferred idiom here would be:

    capabilities.platformName = "playstation"_s;

Unless that doesn’t compile for some reason?
Comment 5 Chris Dumez 2022-04-12 11:53:12 PDT 
Comment on attachment 457304 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457304&action=review

>> Source/WebDriver/playstation/WebDriverServicePlayStation.cpp:48
>> +    capabilities.platformName = String::fromLatin1("playstation");
> 
> The preferred idiom here would be:
> 
>     capabilities.platformName = "playstation"_s;
> 
> Unless that doesn’t compile for some reason?

Agreed, that's a clear use case for ASCIILiteral / ""_s.