WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 239090
Add PlayStation builds to bot watcher's dashboard.
https://bugs.webkit.org/show_bug.cgi?id=239090
Summary
Add PlayStation builds to bot watcher's dashboard.
Ross Kirsling
Reported
2022-04-11 15:28:55 PDT
Add PlayStation builds to bot watcher's dashboard.
Attachments
Patch
(22.57 KB, patch)
2022-04-11 15:33 PDT
,
Ross Kirsling
no flags
Details
Formatted Diff
Diff
Patch
(22.17 KB, patch)
2022-04-12 15:28 PDT
,
Ross Kirsling
no flags
Details
Formatted Diff
Diff
Patch for landing
(3.53 KB, patch)
2022-04-13 13:12 PDT
,
Ross Kirsling
no flags
Details
Formatted Diff
Diff
Patch for landing
(22.18 KB, patch)
2022-04-13 13:22 PDT
,
Ross Kirsling
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Ross Kirsling
Comment 1
2022-04-11 15:33:09 PDT
Created
attachment 457294
[details]
Patch
Jonathan Bedard
Comment 2
2022-04-11 15:58:03 PDT
Comment on
attachment 457294
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=457294&action=review
> Tools/CISupport/.gitignore:-8 > -public_html/
I think Aakash put this in quite deliberately because we end up with a bunch of logs in this directory on build.webkit.org.
Ross Kirsling
Comment 3
2022-04-11 16:01:03 PDT
(In reply to Jonathan Bedard from
comment #2
)
> Comment on
attachment 457294
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=457294&action=review
> > > Tools/CISupport/.gitignore:-8 > > -public_html/ > > I think Aakash put this in quite deliberately because we end up with a bunch > of logs in this directory on build.webkit.org.
Okay, but it means that we can't add new files to the directory, so we'd need to replace it with something more specific.
Darin Adler
Comment 4
2022-04-12 14:39:37 PDT
Comment on
attachment 457294
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=457294&action=review
>>> Tools/CISupport/.gitignore:-8 >>> -public_html/ >> >> I think Aakash put this in quite deliberately because we end up with a bunch of logs in this directory on build.webkit.org. > > Okay, but it means that we can't add new files to the directory, so we'd need to replace it with something more specific.
Are you sure that’s what it means? I’m pretty sure it just means git won’t complain when there are stray files; should not prevent doing a "git add" and committing the files.
Ross Kirsling
Comment 5
2022-04-12 15:19:16 PDT
No, I mean it's not me performing cleanup; I was physically unable to create this patch without it:
> λ git add Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png > The following paths are ignored by one of your .gitignore files: > Tools/CISupport/build-webkit-org/public_html > hint: Use -f if you really want to add them. > hint: Turn this message off by running > hint: "git config advice.addIgnoredFile false"
Ross Kirsling
Comment 6
2022-04-12 15:28:18 PDT
(In reply to Ross Kirsling from
comment #5
)
> No, I mean it's not me performing cleanup; I was physically unable to create > this patch without it: > > > λ git add Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png > > The following paths are ignored by one of your .gitignore files: > > Tools/CISupport/build-webkit-org/public_html > > hint: Use -f if you really want to add them. > > hint: Turn this message off by running > > hint: "git config advice.addIgnoredFile false"
Er, I guess that "hint" does work, so for the sake of this patch I can drop that change, but we definitely shouldn't being gitignoring committed files...the workaround here seems more like a bug than a feature to me. :-/
Ross Kirsling
Comment 7
2022-04-12 15:28:27 PDT
Created
attachment 457483
[details]
Patch
Jonathan Bedard
Comment 8
2022-04-13 11:17:59 PDT
(In reply to Ross Kirsling from
comment #6
)
> (In reply to Ross Kirsling from
comment #5
) > > No, I mean it's not me performing cleanup; I was physically unable to create > > this patch without it: > > > > > λ git add Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlayStation.png > > > The following paths are ignored by one of your .gitignore files: > > > Tools/CISupport/build-webkit-org/public_html > > > hint: Use -f if you really want to add them. > > > hint: Turn this message off by running > > > hint: "git config advice.addIgnoredFile false" > > Er, I guess that "hint" does work, so for the sake of this patch I can drop > that change, but we definitely shouldn't being gitignoring committed > files...the workaround here seems more like a bug than a feature to me. :-/
We should make a more narrow ignore, yeah, need to take a look on one of these bots to see exactly which files we're interested in ignoring.
EWS
Comment 9
2022-04-13 11:59:44 PDT
Tools/Scripts/svn-apply failed to apply
attachment 457483
[details]
to trunk. Please resolve the conflicts and upload a new patch.
Ross Kirsling
Comment 10
2022-04-13 13:12:04 PDT
Created
attachment 457564
[details]
Patch for landing
Ross Kirsling
Comment 11
2022-04-13 13:22:56 PDT
Created
attachment 457565
[details]
Patch for landing
EWS
Comment 12
2022-04-13 14:03:58 PDT
Tools/Scripts/svn-apply failed to apply
attachment 457565
[details]
to trunk. Please resolve the conflicts and upload a new patch.
Ross Kirsling
Comment 13
2022-04-13 14:15:05 PDT
So yeah, this patch cannot be landed without fixing the .gitignore then.
Ross Kirsling
Comment 14
2022-04-13 14:47:14 PDT
(In reply to Ross Kirsling from
comment #13
)
> So yeah, this patch cannot be landed without fixing the .gitignore then.
...landed via CQ, I should say. Going to try landing this via GitHub.
EWS
Comment 15
2022-04-13 16:25:33 PDT
Committed
r292843
(
249616@main
): <
https://commits.webkit.org/249616@main
> Reviewed commits have been landed. Closing PR #284 and removing active labels.
Radar WebKit Bug Importer
Comment 16
2022-04-13 16:26:15 PDT
<
rdar://problem/91722149
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug