Bug 239087 – REGRESSION (r292696): lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string is a constant failure

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Karl Rackler]

lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string

The first build that the failure is seen on: 
https://build.webkit.org/#/builders/370/builds/2637

Diff: 
  Traceback (most recent call last):
    File "/Volumes/Data/worker/monterey-release-applesilicon-tests-wk2/build/Tools/lldb/lldb_webkit_unittest.py", line 110, in serial_test_WTFStringImpl_SummaryProvider_null_string
      self.assertEqual(summary, "{ length = 0, is8bit = 1, contents = '' }")
  AssertionError: '' != "{ length = 0, is8bit = 1, contents = '' }"
  + { length = 0, is8bit = 1, contents = '' }

[Chris Dumez]

Created attachment 457287 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/91589463>

[EWS]

Committed r292750 (249534@main): <https://commits.webkit.org/249534@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457287 [details].

[Darin Adler]

Comment on attachment 457287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457287&action=review

> Tools/ChangeLog:9
> +        Revert change to aNullString made in r292696 as the the following test relies on this String being empty:
> +        lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string

Someone named an empty string "aNullString"! Great way to set a trap for Chris.

[Alexey Proskuryakov]

We also have "anEmptyString" right below. Which is now identical to aNullString.

[Chris Dumez]

(In reply to Alexey Proskuryakov from comment #5)
> We also have "anEmptyString" right below. Which is now identical to
> aNullString.

Yes, aNullString and anEmptyString are identical now and historically (before I tried to fix this non-sense recently and failed because I didn't realize this python test somehow relies on these).