Bug 23906 - Add custom V8 bindings for HTMLPlugInElement
Summary: Add custom V8 bindings for HTMLPlugInElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-11 16:07 PST by Dimitri Glazkov (Google)
Modified: 2009-02-12 10:18 PST (History)
0 users

See Also:


Attachments
Add custom V8 bindings for HTMLPlugInElement, v1. (5.06 KB, patch)
2009-02-11 16:09 PST, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff
Add custom V8 bindings for HTMLPlugInElement, v1.1. (5.16 KB, patch)
2009-02-11 16:19 PST, Dimitri Glazkov (Google)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-02-11 16:07:34 PST
Unfortunately, this doesn't yet move the npobject/npruntime stuff. That would come last.
Comment 1 Dimitri Glazkov (Google) 2009-02-11 16:09:05 PST
Created attachment 27577 [details]
Add custom V8 bindings for HTMLPlugInElement, v1.

 WebCore/ChangeLog                                  |   14 +++
 .../v8/custom/V8HTMLPlugInElementCustom.cpp        |  103 ++++++++++++++++++++
 2 files changed, 117 insertions(+), 0 deletions(-)
Comment 2 Eric Seidel (no email) 2009-02-11 16:10:35 PST
Comment on attachment 27577 [details]
Add custom V8 bindings for HTMLPlugInElement, v1.

Same comments as I made on http://codereview.chromium.org/20281 otherwise looks fine.
Comment 3 Dimitri Glazkov (Google) 2009-02-11 16:11:11 PST
Comment on attachment 27577 [details]
Add custom V8 bindings for HTMLPlugInElement, v1.

New patch coming up.
Comment 4 Dimitri Glazkov (Google) 2009-02-11 16:19:01 PST
Created attachment 27578 [details]
Add custom V8 bindings for HTMLPlugInElement, v1.1.

 WebCore/ChangeLog                                  |   14 +++
 .../v8/custom/V8HTMLPlugInElementCustom.cpp        |  111 ++++++++++++++++++++
 2 files changed, 125 insertions(+), 0 deletions(-)
Comment 5 Dimitri Glazkov (Google) 2009-02-11 16:20:54 PST
Comment on attachment 27578 [details]
Add custom V8 bindings for HTMLPlugInElement, v1.1.

Changes addressed. Hit me.
Comment 6 Eric Seidel (no email) 2009-02-11 16:31:42 PST
Comment on attachment 27578 [details]
Add custom V8 bindings for HTMLPlugInElement, v1.1.

Looks fine.  But why do we sometimes return an empty value handle and sometimes an empty object handle?  Do we care?  Why aren't we consistent?

Seems eventually we should replace all these empty returns with something like:

return emptyHandle();

which does the right hting, whatever that is.
Comment 7 Dimitri Glazkov (Google) 2009-02-12 10:18:57 PST
Landed as http://trac.webkit.org/changeset/40911.