Bug 23906 – Add custom V8 bindings for HTMLPlugInElement

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Dimitri Glazkov (Google)]

Unfortunately, this doesn't yet move the npobject/npruntime stuff. That would come last.

[Dimitri Glazkov (Google)]

Created attachment 27577 [details]
Add custom V8 bindings for HTMLPlugInElement, v1.

 WebCore/ChangeLog                                  |   14 +++
 .../v8/custom/V8HTMLPlugInElementCustom.cpp        |  103 ++++++++++++++++++++
 2 files changed, 117 insertions(+), 0 deletions(-)

[Eric Seidel (no email)]

Comment on attachment 27577 [details]
Add custom V8 bindings for HTMLPlugInElement, v1.

Same comments as I made on http://codereview.chromium.org/20281 otherwise looks fine.

[Dimitri Glazkov (Google)]

Comment on attachment 27577 [details]
Add custom V8 bindings for HTMLPlugInElement, v1.

New patch coming up.

[Dimitri Glazkov (Google)]

Created attachment 27578 [details]
Add custom V8 bindings for HTMLPlugInElement, v1.1.

 WebCore/ChangeLog                                  |   14 +++
 .../v8/custom/V8HTMLPlugInElementCustom.cpp        |  111 ++++++++++++++++++++
 2 files changed, 125 insertions(+), 0 deletions(-)

[Dimitri Glazkov (Google)]

Comment on attachment 27578 [details]
Add custom V8 bindings for HTMLPlugInElement, v1.1.

Changes addressed. Hit me.

[Eric Seidel (no email)]

Comment on attachment 27578 [details]
Add custom V8 bindings for HTMLPlugInElement, v1.1.

Looks fine.  But why do we sometimes return an empty value handle and sometimes an empty object handle?  Do we care?  Why aren't we consistent?

Seems eventually we should replace all these empty returns with something like:

return emptyHandle();

which does the right hting, whatever that is.

[Dimitri Glazkov (Google)]

Landed as http://trac.webkit.org/changeset/40911.