RESOLVED FIXED 239050
[WebGPU] Implement correct ownership for WGPUQueues 
https://bugs.webkit.org/show_bug.cgi?id=239050
Summary [WebGPU] Implement correct ownership for WGPUQueues
Myles C. Maxfield
Reported 2022-04-10 11:12:34 PDT
.
Attachments
Patch (65.30 KB, patch)
2022-04-10 11:34 PDT, Myles C. Maxfield 		kkinnunen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-04-10 11:34:59 PDT
Created attachment 457205 [details] Patch
Kimmo Kinnunen
Comment 2 2022-04-11 01:15:35 PDT
Comment on attachment 457205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457205&action=review > Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:-1964 > - DD20DE6027BC90D80093D175 /* Gunzip.h in Headers */, I wonder what this reordering is about.. > Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceHolderImpl.h:37 > +class ConvertToBackingContext; redundant forward declare?
Myles C. Maxfield
Comment 3 2022-04-11 16:27:46 PDT
Comment on attachment 457205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457205&action=review >> Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:-1964 >> - DD20DE6027BC90D80093D175 /* Gunzip.h in Headers */, > > I wonder what this reordering is about.. I'll land this part separately. >> Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceHolderImpl.h:37 >> +class ConvertToBackingContext; > > redundant forward declare? Good catch.
Myles C. Maxfield
Comment 4 2022-04-11 16:28:29 PDT
Committed r292735 (249520@trunk): <https://commits.webkit.org/249520@trunk>
Radar WebKit Bug Importer
Comment 5 2022-04-11 16:29:15 PDT
<rdar://problem/91595566>
Myles C. Maxfield
Comment 6 2022-04-11 16:29:22 PDT
Comment on attachment 457205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457205&action=review >>> Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:-1964 >>> - DD20DE6027BC90D80093D175 /* Gunzip.h in Headers */, >> >> I wonder what this reordering is about.. > > I'll land this part separately. https://trac.webkit.org/changeset/292735/webkit
Myles C. Maxfield
Comment 7 2022-04-11 17:07:26 PDT
Committed r292742 (249526@trunk): <https://commits.webkit.org/249526@trunk>
Note You need to log in before you can comment on or make changes to this bug.