Bug 239032 - [Flatpak] clangd wrapper improvements
Summary: [Flatpak] clangd wrapper improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-09 09:00 PDT by Philippe Normand
Modified: 2022-04-10 09:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.22 KB, patch)
2022-04-09 09:06 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2022-04-09 09:00:31 PDT 
.
Comment 1 Philippe Normand 2022-04-09 09:06:14 PDT 
Created attachment 457166 [details]
Patch
Comment 2 Philippe Normand 2022-04-09 09:52:46 PDT 
I wonder also, why not pass --enable-config directly to clangd from the wrapper?
Comment 3 Adrian Perez 2022-04-09 14:00:28 PDT 
(In reply to Philippe Normand from comment #2)
> I wonder also, why not pass --enable-config directly to clangd from the
> wrapper?

Maybe to avoid arbitrary user configurations breaking how clangd works?
Imagine an user's ~/.clangd file adding -std=c++11 and breaking things.
Comment 4 Philippe Normand 2022-04-09 14:22:43 PDT 
(In reply to Adrian Perez from comment #3)
> (In reply to Philippe Normand from comment #2)
> > I wonder also, why not pass --enable-config directly to clangd from the
> > wrapper?
> 
> Maybe to avoid arbitrary user configurations breaking how clangd works?
> Imagine an user's ~/.clangd file adding -std=c++11 and breaking things.

The doc explicitly mentions this option, that's why i'm asking.

https://trac.webkit.org/wiki/WebKitEnablingFlatpakClangd
Comment 5 EWS 2022-04-10 09:48:27 PDT 
Committed r292687 (249479@main): <https://commits.webkit.org/249479@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457166 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-10 09:52:28 PDT 
<rdar://problem/91536540>