Bug 239030 - Fails to build with error: use of undeclared identifier 'LC_MESSAGES'
Summary: Fails to build with error: use of undeclared identifier 'LC_MESSAGES'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-09 07:48 PDT by Khem Raj
Modified: 2022-04-09 19:15 PDT (History)
11 users (show)

See Also:

Attachments
proposed fix (1.00 KB, patch)
2022-04-09 08:14 PDT, Khem Raj 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Khem Raj 2022-04-09 07:48:13 PDT 
when building with clang14 webkit 2.36 is failing to build and following error message is seen

TOPDIR/build/tmp/work/core2-32-yoe-linux/webkitgtk/2.36.0-r0/webkitgtk-2.36.0/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp:115:51: error: use of undeclared identifier 'LC_MESSAGES'
            return g_variant_new_string(setlocale(LC_MESSAGES, nullptr));
                                                  ^
1 error generated.

We need to include locale.h for getting LC_MESSAGES definition
Comment 1 Khem Raj 2022-04-09 08:14:47 PDT 
Created attachment 457164 [details]
proposed fix
Comment 2 EWS 2022-04-09 19:15:20 PDT 
Committed r292684 (249476@main): <https://commits.webkit.org/249476@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457164 [details].