Bug 239028 – Clean up Element::isFocusableWithoutResolvingFullStyle()

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Tim Nguyen (:ntim)]

Clean up isFocusableWithoutResolvingFullStyle() by using a shared lambda for different checks.

[Tim Nguyen (:ntim)]

Created attachment 457161 [details]
Patch

[Darin Adler]

Comment on attachment 457161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457161&action=review

> Source/WebCore/dom/Element.cpp:3560
> +    auto isFocusableStyle = [](const RenderStyle* style) -> bool {

Since this won’t work on null, it should take RenderStyle&, not *.

> Source/WebCore/dom/Element.cpp:3568
> +        return isFocusableStyle(renderStyle());

And we would put the * here at the call site.

[Radar WebKit Bug Importer]

<rdar://problem/91848897>

[Tim Nguyen (:ntim)]

Created attachment 457814 [details]
Patch

[Tim Nguyen (:ntim)]

(In reply to Darin Adler from comment #2)
> Comment on attachment 457161 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457161&action=review
> 
> > Source/WebCore/dom/Element.cpp:3560
> > +    auto isFocusableStyle = [](const RenderStyle* style) -> bool {
> 
> Since this won’t work on null, it should take RenderStyle&, not *.

Yeah, the previous version crashed as EWS showed, made it check for the style's existence as well so I don't duplicate it.

[Antti Koivisto]

Comment on attachment 457814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457814&action=review

> Source/WebCore/dom/Element.cpp:3560
> +    auto isFocusableStyle = [](const RenderStyle* style) -> bool {

->bool is not necessary

[Tim Nguyen (:ntim)]

Created attachment 457868 [details]
[fast-cq] Patch

[EWS]

Committed r293011 (249750@main): <https://commits.webkit.org/249750@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457868 [details].